Skip to content

[Fix/#68] 릴리즈 직전 세부 항목 수정 #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2025
Merged

[Fix/#68] 릴리즈 직전 세부 항목 수정 #69

merged 2 commits into from
Jul 31, 2025

Conversation

l5x5l
Copy link
Contributor

@l5x5l l5x5l commented Jul 31, 2025 •
edited by coderabbitai bot
Loading

[ PR Content ]

  • 1.0.0 버전 배포 직전 발견한 세부 항목들을 수정합니다

Related issue

Screenshot 📸

KakaoTalk_Video_2025-07-31-23-02-03.mp4

Work Description

  • 감정 구슬 선택 이후 추천 루틴 표시 화면에서 상단 statusbar 부분 패딩이 적용되지 않는 부분을 수정했습니다
  • 마이페이지 내 공지사항, 자주 묻는 질문 선택시 각 url을 표시하는 WebView 화면으로 이동합니다
  • 홈 화면의 fab버튼 클릭시 나오는 "제보하기" 버튼을 누르면 준비중임을 알리는 토스트 메세지가 표시됩니다

To Reviewers 📢

  • 빠진 부분 있다면 코멘트 부탁드립니다!

Summary by CodeRabbit

  • 신규 기능

    • 홈 화면에서 "공지 사항" 및 "자주 묻는 질문" 메뉴 선택 시, 각각 지정된 웹뷰 화면으로 이동하도록 개선되었습니다.

  • 버그 수정

    • "제보하기" 버튼 클릭 시, 해당 기능이 추후 제공될 예정임을 알리는 안내 메시지가 표시됩니다.

  • 스타일

    • 추천 루틴 화면 상단에 상태바 패딩이 추가되어, 콘텐츠가 시스템 상태바와 겹치지 않도록 개선되었습니다.

@l5x5l l5x5l requested a review from wjdrjs00 July 31, 2025 14:03
@l5x5l l5x5l self-assigned this Jul 31, 2025
@l5x5l l5x5l added 🐞 Fix 버그 수정 세환 labels Jul 31, 2025
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 31, 2025 •
edited
Loading

Walkthrough

이번 변경에서는 감정 구슬 선택 후 추천 루틴 화면에 status bar 패딩을 추가하고, 마이페이지 내 공지사항 및 자주 묻는 질문 선택 시 각각의 WebView로 이동하도록 네비게이션을 구현하였습니다. 또한 홈 화면의 "제보하기" 버튼 클릭 시 안내 토스트가 표시되도록 수정되었습니다.

Changes

Cohort / File(s) Change Summary
마이페이지 WebView 네비게이션 추가
app/src/main/java/com/threegap/bitnagil/MainNavHost.kt		 공지사항 및 자주 묻는 질문 클릭 시 각각의 Notion WebView로 이동하도록 네비게이션 람다 구현
홈 화면 제보하기 안내 토스트
app/src/main/java/com/threegap/bitnagil/navigation/home/HomeNavHost.kt		 "제보하기" 버튼 클릭 시 안내 토스트 메시지 노출 기능 추가
감정 루틴 화면 StatusBar 패딩 적용
presentation/src/main/java/com/threegap/bitnagil/presentation/emotion/EmotionScreen.kt		 추천 루틴 화면 상단에 status bar 패딩 추가 (.statusBarsPadding() 적용)

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MainNavHost
    participant WebViewScreen

    User->>MainNavHost: 공지사항/자주 묻는 질문 클릭
    MainNavHost->>WebViewScreen: WebView로 네비게이션 (타이틀, URL 전달)
Loading 
sequenceDiagram
    participant User
    participant HomeNavHost
    participant Toast

    User->>HomeNavHost: 제보하기 버튼 클릭
    HomeNavHost->>Toast: "제보하기 기능은 추후 제공" 안내 토스트 표시
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Assessment against linked issues

Objective Addressed Explanation
감정 구슬 선택 화면 내 상단 statusbar 패딩 적용 (#68) ✅
공지사항/자주 묻는 질문 webview 연결 (#68) ✅

Possibly related PRs

Suggested labels

🧤 대현

Poem

토끼가 깡총, 코드를 살펴봐요
패딩이 생겨 화면이 더 예뻐요
공지와 질문도 클릭하면 쏙!
웹뷰로 이동해 궁금증 뚝딱
제보하기는 잠시만 기다려요
오늘도 변화에 깡총, 기분 좋은 하루! 🐰✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e01eb48 and b39747b.

📒 Files selected for processing (3)
  • app/src/main/java/com/threegap/bitnagil/MainNavHost.kt (1 hunks)
  • app/src/main/java/com/threegap/bitnagil/navigation/home/HomeNavHost.kt (1 hunks)
  • presentation/src/main/java/com/threegap/bitnagil/presentation/emotion/EmotionScreen.kt (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: presentation/src/main/java/com/threegap/bitnagil/presentation/writeroutine/component/atom/textbutton... 
Learnt from: l5x5l
PR: YAPP-Github/Bitnagil-Android#38
File: presentation/src/main/java/com/threegap/bitnagil/presentation/writeroutine/component/atom/textbutton/TextButton.kt:30-35
Timestamp: 2025-07-21T10:38:49.104Z
Learning: presentation/src/main/java/com/threegap/bitnagil/presentation/writeroutine/component/atom/textbutton/TextButton.kt의 TextButton 컴포넌트는 임시로 구현된 컴포넌트로, 디자인 시스템 구현시 대체 예정입니다.

Applied to files:

  • app/src/main/java/com/threegap/bitnagil/navigation/home/HomeNavHost.kt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (4)
presentation/src/main/java/com/threegap/bitnagil/presentation/emotion/EmotionScreen.kt (1)

151-152: 상태바 패딩 적용 완료!

감정 구슬 선택 후 추천 루틴 화면에 .statusBarsPadding() 모디파이어가 올바르게 추가되어 시스템 상태바와의 겹침 문제가 해결되었습니다. EmotionScreen에서도 동일한 패턴을 사용하고 있어 일관성이 유지됩니다.

app/src/main/java/com/threegap/bitnagil/navigation/home/HomeNavHost.kt (1)

106-106: 사용자 피드백 개선 완료!

"제보하기" 기능의 onClick 핸들러에 적절한 안내 토스트 메시지가 구현되어 사용자에게 해당 기능이 준비 중임을 명확히 알려줍니다. 빈 람다에서 의미 있는 사용자 피드백으로 개선된 좋은 변경사항입니다.

app/src/main/java/com/threegap/bitnagil/MainNavHost.kt (2)

104-109: 공지사항 네비게이션 구현 완료!

공지사항 선택 시 적절한 제목과 URL로 WebView 화면으로 이동하는 네비게이션이 올바르게 구현되었습니다. 기존 약관 동의 네비게이션과 동일한 패턴을 따르고 있어 코드 일관성이 유지됩니다.

112-117: 자주 묻는 질문 네비게이션 구현 완료!

자주 묻는 질문 선택 시 WebView로 이동하는 기능이 정상적으로 구현되었습니다. 공지사항과 동일한 구조로 일관성 있게 작성되어 있습니다.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/#68-detail_fix_before_release_1.0.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

wjdrjs00
wjdrjs00 approved these changes Jul 31, 2025
View reviewed changes
Copy link
Member

@wjdrjs00 wjdrjs00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~!

@l5x5l l5x5l merged commit 1c6d67b into develop Jul 31, 2025
2 checks passed
@l5x5l l5x5l deleted the fix/#68-detail_fix_before_release_1.0.0 branch July 31, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjdrjs00 wjdrjs00 wjdrjs00 approved these changes

Assignees

@l5x5l l5x5l

Labels

세환 🐞 Fix 버그 수정

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FIX] 세부 항목 수정

2 participants

@l5x5l @wjdrjs00