[Fix/#76] 추천 루틴 화면 패딩 영역 수정

[wjdrjs00]

[ PR Content ]

추천 루틴 화면 패딩 영역관련 이슈를 해결했습니다.

Related issue

• closed [FIX] 추천 루틴 화면 패딩 영역 수정 #76

Screenshot 📸

Screen_recording_20250807_140530.mp4

Work Description

• homeNavHost innerPadding 적용
• 추천 루틴 화면 패딩 영역 수정

To Reviewers 📢

• N/A

Summary by CodeRabbit

• 스타일

  • 홈 화면에서 내비게이션 호스트의 패딩 처리가 명확하게 조정되어, 스캐폴드의 인셋이 0으로 설정되었습니다.

• 개선사항

  • 추천 루틴 화면의 목록 하단에 110dp 높이의 여백이 추가되어, 스크롤 시 하단 공간이 넉넉해졌습니다.

[coderabbitai]

Walkthrough

HomeNavHost.kt에서 Scaffold의 contentWindowInsets가 명시적으로 0으로 설정되었고, content 람다의 파라미터가 innerPadding으로 변경되어 NavHost의 패딩에 적용되었습니다. RecommendRoutineScreen.kt에서는 LazyColumn의 마지막에 110.dp 높이의 스페이서가 추가되어 하단 패딩이 늘어났습니다.

Changes

Cohort / File(s)	Change Summary
Scaffold 및 NavHost 패딩 처리 개선 app/src/main/java/com/threegap/bitnagil/navigation/home/HomeNavHost.kt	Scaffold의 contentWindowInsets를 0으로 설정하고, innerPadding을 NavHost의 패딩에 적용함.
추천 루틴 화면 하단 패딩 추가 presentation/src/main/java/com/threegap/bitnagil/presentation/recommendroutine/RecommendRoutineScreen.kt	LazyColumn 마지막에 110.dp 스페이서 추가로 하단 패딩 확보.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant RecommendRoutineScreen
    participant LazyColumn
    participant Spacer

    User->>RecommendRoutineScreen: 화면 진입
    RecommendRoutineScreen->>LazyColumn: 루틴 리스트 렌더링
    LazyColumn->>Spacer: 마지막에 110.dp Spacer 추가
    Spacer-->>User: 바텀네비 위 패딩 확보

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Assessment against linked issues

Objective	Addressed	Explanation
추천 루틴 화면 패딩 영역 조정 및 바텀네비게이션바에 가려지지 않게 마지막 루틴까지 표시 (#76)	✅

Suggested labels

세환

Poem

토끼가 말하길, 패딩을 더했죠,
루틴이 바텀에 가려질 일 없게 했죠!
110.dp 스페이서로 공간이 넉넉,
이제 모든 루틴이 한눈에 쏙쏙!
🐰✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/#76-rouitne-recommend-ui

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

presentation/src/main/java/com/threegap/bitnagil/presentation/recommendroutine/RecommendRoutineScreen.kt (1)

177-179: 하단 스페이서 추가로 콘텐츠 가시성 개선

LazyColumn 하단에 110.dp 스페이서를 추가하여 추천 루틴 목록이 하단 네비게이션 바에 가려지지 않도록 한 것은 문제를 효과적으로 해결합니다.

다만 110.dp라는 하드코딩된 값이 하단 네비게이션 바 높이가 변경될 경우 유지보수성에 영향을 줄 수 있습니다. 가능하다면 테마나 상수로 관리하는 것을 고려해보세요.

향후 개선을 위한 제안:

+// Constants.kt 또는 테마에서
+val BottomNavigationSpacing = 110.dp

-                item {
-                    Spacer(modifier = Modifier.height(110.dp))
-                }
+                item {
+                    Spacer(modifier = Modifier.height(BottomNavigationSpacing))
+                }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between af43a04 and fe0f968.

📒 Files selected for processing (2)

• app/src/main/java/com/threegap/bitnagil/navigation/home/HomeNavHost.kt (2 hunks)
• presentation/src/main/java/com/threegap/bitnagil/presentation/recommendroutine/RecommendRoutineScreen.kt (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build

🔇 Additional comments (1)

app/src/main/java/com/threegap/bitnagil/navigation/home/HomeNavHost.kt (1)

57-62: 하단 내비게이션 바와 콘텐츠 간의 패딩 관리 개선

contentWindowInsets를 명시적으로 0으로 설정하고 innerPadding을 NavHost에 적용한 것은 좋은 접근입니다. 이를 통해 시스템 윈도우 인셋을 수동으로 제어할 수 있고, 스캐폴드가 계산한 패딩(하단 네비게이션 바 공간 포함)을 정확히 적용할 수 있습니다.

[l5x5l]

고생 많으셨어요! compose상의 insets관련해서는 한번 조사해보겠습니다!