[Refactor/#93] BitnagilTextButton 공통 컴포넌트 수정 #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughBitnagilTextButton 컴포넌트 내부에서 fillMaxWidth()를 제거하고, 대신 각 사용처에서 modifier로 fillMaxWidth()를 명시적으로 전달하도록 변경했습니다. 이에 따라 여러 화면에서 해당 버튼의 modifier에 fillMaxWidth()를 추가하여 버튼이 전체 너비를 차지하도록 수정되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant Caller as 호출부(화면)
participant BitnagilTextButton as BitnagilTextButton
Caller->>BitnagilTextButton: modifier = Modifier.fillMaxWidth()
BitnagilTextButton-->>Caller: 버튼 렌더링 (modifier 적용)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes(해당 변경사항에는 linked issue의 목적에서 벗어난 변경사항이 없습니다.) Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
presentation/src/main/java/com/threegap/bitnagil/presentation/writeroutine/WriteRoutineScreen.kt (1)
336-338: 호출부에서 폭 제어 명시 — OK
BitnagilTextButton에fillMaxWidth()를 명시해 이전 레이아웃을 유지한 점 좋습니다.소소한 스타일 제안:
- 팀 컨벤션이 있다면(예: 크기 → 간격 순), 아래처럼 순서를 통일하면 가독성이 좋아집니다.
-modifier = Modifier - .padding(start = 16.dp, end = 16.dp, top = 14.dp, bottom = 14.dp) - .fillMaxWidth(), +modifier = Modifier + .fillMaxWidth() + .padding(start = 16.dp, end = 16.dp, top = 14.dp, bottom = 14.dp),presentation/src/main/java/com/threegap/bitnagil/presentation/writeroutine/component/template/TimePickerBottomSheet.kt (2)
109-112: 사용처에서 폭 제어 명시 — OK (소소한 순서 통일 제안)레이아웃은 문제없습니다. 다만 다른 파일과의 일관성을 위해 순서를 통일하면 읽기 쉬워집니다.
-modifier = Modifier - .padding(start = 16.dp, end = 16.dp, bottom = 14.dp) - .fillMaxWidth(), +modifier = Modifier + .fillMaxWidth() + .padding(start = 16.dp, end = 16.dp, bottom = 14.dp),
85-87: 불필요한 객체 생성 제거 제안
AndroidView의 factory에서TimePicker(context).apply { setIs24HourView(true) }를 생성하지만 사용하지 않습니다. 인플레이트한 뷰의timePicker에 설정하거나, 불필요 생성 코드를 제거하세요.- TimePicker(context).apply { - setIs24HourView(true) - } + // 필요 시 아래처럼 inflate된 timePicker에 적용: + // (spinner_time_picker 레이아웃이 24h 설정을 포함하지 않는다면) + (view.findViewById<TimePicker>(R.id.time_picker))?.setIs24HourView(true)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
core/designsystem/src/main/java/com/threegap/bitnagil/designsystem/component/atom/BitnagilTextButton.kt(2 hunks)presentation/src/main/java/com/threegap/bitnagil/presentation/emotion/EmotionScreen.kt(3 hunks)presentation/src/main/java/com/threegap/bitnagil/presentation/onboarding/component/template/OnBoardingSelectTemplate.kt(3 hunks)presentation/src/main/java/com/threegap/bitnagil/presentation/writeroutine/WriteRoutineScreen.kt(1 hunks)presentation/src/main/java/com/threegap/bitnagil/presentation/writeroutine/component/template/TimePickerBottomSheet.kt(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-21T10:38:49.104Z
Learnt from: l5x5l
PR: YAPP-Github/Bitnagil-Android#38
File: presentation/src/main/java/com/threegap/bitnagil/presentation/writeroutine/component/atom/textbutton/TextButton.kt:30-35
Timestamp: 2025-07-21T10:38:49.104Z
Learning: presentation/src/main/java/com/threegap/bitnagil/presentation/writeroutine/component/atom/textbutton/TextButton.kt의 TextButton 컴포넌트는 임시로 구현된 컴포넌트로, 디자인 시스템 구현시 대체 예정입니다.
Applied to files:
core/designsystem/src/main/java/com/threegap/bitnagil/designsystem/component/atom/BitnagilTextButton.kt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (2)
presentation/src/main/java/com/threegap/bitnagil/presentation/onboarding/component/template/OnBoardingSelectTemplate.kt (1)
5-5: 사용처에서 폭 제어 명시 — OK
다음,건너뛰기모두Modifier.fillMaxWidth()적용으로 의도대로 전체 폭을 차지합니다.- 상위 Column의 좌우 패딩과도 정렬되어 UI 일관성이 유지됩니다.
Also applies to: 80-81, 92-93
presentation/src/main/java/com/threegap/bitnagil/presentation/emotion/EmotionScreen.kt (1)
10-10: 사용처에서 폭 제어 명시 — OK
변경하기,건너뛰기버튼 모두 폭 제어를 호출부로 이관하여 일관성 있게 유지했습니다.건너뛰기는 배경 투명 처리와 조합되어 디자인 의도에 부합합니다.Also applies to: 204-205, 219-220
...system/src/main/java/com/threegap/bitnagil/designsystem/component/atom/BitnagilTextButton.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ PR Content ]
Related issue
Screenshot 📸
Work Description
To Reviewers 📢
Summary by CodeRabbit