Add TSC support to Tron #1003
Merged
Add TSC support to Tron #1003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires a task_processing bump to allow for starting pods with Topology Spread Constraints (TSCs) as well as a PaaSTA one (that will be merged after this is fully deployed) to start configuring this. NOTE: since this is adding new data that will be serialized, reverting this will not be as straightforward as reverting this commit: we would need to leave the config classes laying around so that we can still deserialize the pickles
nemacysts
requested review from
EmanElsaban,
EvanKrall,
KaspariK,
ilkinmammadzada and
jfongatyelp
|
requires Yelp/task_processing#220 |
jfongatyelp
approved these changes
Oct 24, 2024
These should be discovered as part of the mesos_executor extra -- and this is in fact happening on my devbox -- but for some reason GHA isn't seeing these requirements are actually depended upon
nemacysts
commented
Oct 28, 2024
There was a problem hiding this comment.
this change really shouldn't be necessary (and check-requirements is fine internally without this) - but i couldn't figure out what's going on
(and in any case, hopefully we can de-pickle things in the near future and actually delete all the unused mesos code)
jfongatyelp
approved these changes
Oct 28, 2024
EmanElsaban
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires a task_processing bump to allow for starting pods with Topology Spread Constraints (TSCs) as well as a PaaSTA one (that will be merged after this is fully deployed) to start configuring this.
NOTE: since this is adding new data that will be serialized, reverting this will not be as straightforward as reverting this commit: we would need to leave the config classes laying around so that we can still deserialize the pickles
abridged yaml of a pod launched with this: https://fluffy.yelpcorp.com/i/BV1gwjFrFGFn88cR8SPmpMwspTlmxGmj.html