Allow batches 30s of cleanup time on external kills #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a batch is killed by Tron (i.e., hitting max_runtime) or a human (i.e., tronctl kill), give them 30s to handle any cleanup. Batches that wish to use this feature will need to catch the SIGTERM signal and do whatever cleanup they'd like to do in that handler :)
|
i think that this needs a little more work due to how we end up wrapping the tronfig command, so imma close this for now (since there's also not much demand) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a batch is killed by Tron (i.e., hitting max_runtime) or a human (i.e., tronctl kill), give them 30s to handle any cleanup.
Batches that wish to use this feature will need to catch the SIGTERM signal and do whatever cleanup they'd like to do in that handler :)
NOTE: this requires Yelp/task_processing#218