Remove hiera_or_lookup function entirely #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vulpine
requested review from
bobtfish,
giuliano108,
jvperrin,
mtbentley,
filipposc5,
janpokrzywinski,
vikramjakhr,
ahaswell,
technicaljones and
giuli007
technicaljones
approved these changes
Oct 31, 2022
jvperrin
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than modifying it, we should now be able to remove this function altogether, as it's not referenced at all in our Puppet repo.
We had a bit of a hiccup previously, I think due to a race condition where Puppet would compile the catalogue, remove the function, but then fail due to other functions still referencing it not yet having been updated (see https://yelp.slack.com/archives/CCYF30A1K/p1667238131316119) -- this should not be an issue by the time we ship and apply this, as Puppet should have since updated on all hosts which would have been affected in this interim period.