Add some exponential backoff to k8s watch restarts #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're still seeing task_proc/tron get stuck in pretty hot restart loops for expired resource versions - hopefully backing off a bit will help out here since one current theory we have is that by hitting the apiserver so hard is causing extra load and further exacerbating the issue. If this doesn't work, we'll likely want to switch to a pattern where we have a reconcilliation thread/process periodically reconciling our state with k8s' on top of having the watch always restart from a resourceVersion of 0 (which skips the initial pod listing and starts the watch "now").
nemacysts
added a commit
to Yelp/Tron
that referenced
this pull request
Apr 3, 2025
This includes Yelp/task_processing#225, which should add some backoff to watch restarts to avoid slamming the apiserver
nemacysts
requested review from
EvanKrall,
jfongatyelp,
EmanElsaban and
KaspariK
KaspariK
approved these changes
Apr 3, 2025
nemacysts
added a commit
to Yelp/Tron
that referenced
this pull request
Apr 3, 2025
This includes Yelp/task_processing#225, which should add some backoff to watch restarts to avoid slamming the apiserver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're still seeing task_proc/tron get stuck in pretty hot restart loops for expired resource versions - hopefully backing off a bit will help out here since one current theory we have is that by hitting the apiserver so hard is causing extra load and further exacerbating the issue.
If this doesn't work, we'll likely want to switch to a pattern where we have a reconcilliation thread/process periodically reconciling our state with k8s' on top of having the watch always restart from a resourceVersion of 0 (which skips the initial pod listing and starts the watch "now").