PHPCS: selectively ignore some flagged PHP function deprecations #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PHPCS native `Generic.PHP.DeprecatedFunctions` sniff will flag calls to deprecated functions. As of PHP 8.5, PHP has deprecated a number of functions related to previously done resource to object migrations. For the purposes of this package, we are testing the `assertClosedResource()` polyfill. These tests use a number of deprecated functions, but these tests will only ever be run on PHP versions where the return value from the involved extension was still a resource. In other words, the PHP 8.5 deprecations will never be hit and the PHPCS sniff flagging them can be ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHPCS native
Generic.PHP.DeprecatedFunctionssniff will flag calls to deprecated functions.As of PHP 8.5, PHP has deprecated a number of functions related to previously done resource to object migrations.
For the purposes of this package, we are testing the
assertClosedResource()polyfill. These tests use a number of deprecated functions, but these tests will only ever be run on PHP versions where the return value from the involved extension was still a resource.In other words, the PHP 8.5 deprecations will never be hit and the PHPCS sniff flagging them can be ignored.