Skip to content

feat: add support for yamllint.parse_custom_tags (enable for Pimcore) #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youwe-petervanderwal merged 1 commit into from
Mar 13, 2026
Merged

feat: add support for yamllint.parse_custom_tags (enable for Pimcore) #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [3.0.4]
### Added
- Support for `yamllint.parse_custom_tags` in the GrumPHP yamllint task configuration to allow parsing Symfony/Pimcore YAML custom tags (e.g. `!tagged_iterator`).

## [3.0.3]
### Fixed
- When running GrumPHP on an environment with the Redis PHP extension installed, it errored with `The package
Expand Down
2 changes: 2 additions & 0 deletions config/default/grumphp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ parameters:
- /^pdepend.xml$/

yamllint.parse_constant: true
yamllint.parse_custom_tags: false
Copy link
Copy Markdown
Contributor

@youwe-petervanderwal youwe-petervanderwal Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed to set the default to false (equal to GrumPHP default) and only make the change to default true for Pimcore projects/bundles.

Unless Magento devs say they want to have this changed too (in that case we can set it to true here immediately)

yamllint.whitelist_patterns: []
yamllint.ignore_patterns: []

Expand Down Expand Up @@ -152,6 +153,7 @@ grumphp:

yamllint:
parse_constant: '%yamllint.parse_constant%'
parse_custom_tags: '%yamllint.parse_custom_tags%'
whitelist_patterns: '%yamllint.whitelist_patterns%'
ignore_patterns: '%yamllint.ignore_patterns%'

Expand Down
2 changes: 2 additions & 0 deletions config/pimcore/grumphp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ imports:
parameters:
git_blacklist.triggered_by: [ 'php', 'js', 'twig' ]

yamllint.parse_custom_tags: true

# Disable PHPCS (which is enabled by default) in favour of PHP CS Fixer
phpcs.enabled: false
phpcsfixer.enabled: true
Expand Down
Loading