refactor: remove duplicate zapscript code after go-zapscript migration#534
Merged
wizzomafizzo merged 1 commit intomainfrom Feb 12, 2026
Merged
Conversation
Remove local implementations that duplicate go-zapscript functions: - Delete advargs/helpers.go (IsActionDetails, IsActionRun, IsModeShuffle wrappers that were never called) - Remove ShouldRun from advargs/parse.go (never called, When condition checked directly in commands.go) - Replace NormalizeTag in tags.go with alias to zapscript.NormalizeTag (identical implementation) - Remove NormalizeTagFilter from tags.go (only used in tests, trivial wrapper)
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
advargs/helpers.go—IsActionDetails,IsActionRun,IsModeShufflewere thin wrappers delegating togo-zapscript, never called from production codeShouldRunfromadvargs/parse.go— never called,Whencondition is checked directly incommands.goNormalizeTagintags.gowith avaralias tozapscript.NormalizeTag— identical implementation, removes duplicate regex varsNormalizeTagFilterfromtags.go— only referenced in its own test, never used in production code