-
Notifications
You must be signed in to change notification settings - Fork 177
fix(mempool): Avoid panicking when a transaction is unexpectedly missing in the mempool #10049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
conradoplg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think it just needs making clippy happy
|
@arya2 just a reminder about this PR that should merge before the release, the clippy fix is related to the PR itself |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #10078. You may have to fix your CI before adding the pull request to the queue again. |
…ng from the mempool's verified set instead of panicking
…` where the method could attempt to remove the same transaction twice if it depended on the outputs of another transaction that was just removed. - Fixes an issue where mined transaction dependencies were not being removed from the mempool's transaction dependencies.
…endent transaction ids for a transaction when removing those dependent transaction. Updates `clear_mined_dependencies()` to remove keys in the `dependencies` map with empty values.
Motivation
Closes #10038.
Solution
remove()with tx ids that are not in the mempool.Related:
PR Checklist