Partial ZSA Support: Transaction V6, NU7, generics for backward compatibility, pre-state consensus #9560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actor orchard_shielded_data_iter and orchard_shielded_data_field macros to use it
…te_commitments to merge Orchard ZSA issuance note commitments for V6 transactions
… and refactor orchard_shielded_data_iter and orchard_shielded_data_field macros to use it" This reverts commit 2587b04.
…orchard_shielded_data macro from the reverted commit
…ns from librustzcash/zcash_primitives instead of reimplementing them
… to use the correct order of the asset burn field in V6 transaction as it's defined in ZIP 230
… used in librustzcash
… now - the same as used in librustzcash to make it possible to run tests)
…add issuance_block test function there (now it simply deserialized issuance block from the test vector to check if deserialization functions work properly)
…dd checks of deserialization of transfer and burn blocks
…'re two keys now - VERIFYING_KEY_VANILLA and VERIFYING_KEY_ZSA
… use 77777777 as consensus branch id for Nu7 (to ajdust it with ones used in librustzcash)
conradoplg
added
do-not-merge
Fix the deployment pipeline to ECS to include also the selected docker image tag in the task definition
conradoplg
added
do-not-merge
…cashFoundation#9560) (#63) * Quote variables in push-deploy.yaml to pass upstream actionlint checks The actionlint job in the ZcashFoundation/zebra repository CI reported multiple SC2086 errors. This commit quotes shell variables in push-deploy.yaml to fix the linter failures. * Avoid to use Into ValueCommitment for ShieldedDataFlavor::BurnType, and use compute_burn_value_commitment instead * Rename generic const parameter N of EncryptedNote to SIZE * Remove shielded_data::ActionCommon introduced during ZSA integration, and replace Transaction::orchard_actions() with Transaction::orchard_action_count() * Remove Default trait constraint for BurnType, also remove FIXME comment there * Address PR #63 review comments: make compute_burn_value_commitment non-generic and move comment to the top of the function
…test (#62) * Rename orchard_..._zsa test vector files to orchard_zsa_..., same for structs and consts declardd there * Add tests for empty tx v6 into zebra-chain * Add V6 roundtrip tests based on ORCHARD_ZSA_WORKFLOW_BLOCKS test vectors to zebra-chain * Address PR #62 review comments * Improve OrchardZSA V6 round-trip and conversion tests
oxarbitrage
added
do-not-merge
oxarbitrage
added
do-not-merge
arya2
added
do-not-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
orchard,halo2,zcash_note_encryption, etc.).Tests
Specifications & References
Follow-up Work
PR Checklist