True Elastic DDP on spot instances with K8s StatefulSet workers#1186
Open
True Elastic DDP on spot instances with K8s StatefulSet workers#1186
Conversation
… for elastic training
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1186 +/- ##
========================================
Coverage 99.98% 99.98%
========================================
Files 192 196 +4
Lines 10199 10312 +113
========================================
+ Hits 10197 10310 +113
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b68065b to
3e8332e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: rbac has been updated, will need to be applied in each cluster.
Summary
Key components
ZettaDefaultTrainer: Extended with DCP checkpointing (distributed) andAsyncCheckpointIO(single-node), periodic time-based checkpoints, configurable DDP timeout for fast failure detectionSIGTERMCheckpointCallback: Graceful exit on preemption — sets flag, finishes current step, then exits (no DCP save in handler to avoid distributed deadlock)lightning_train: New params for elastic training (min_nodes,max_restarts,provisioning_model,rdzv_configs), automatic StatefulSet/Service lifecycle managementcapture_pod_logs,watch_for_pod_disruptions,watch_for_run_events,follow_rank0_logs— all run as background threads during training