Skip to content

Button stepper and Markdown Processor FIX #71

Open
ZShubhi wants to merge 18 commits intocommon-snippet-prosfrom
shubhi_menu_compose
Open

Button stepper and Markdown Processor FIX #71
ZShubhi wants to merge 18 commits intocommon-snippet-prosfrom
shubhi_menu_compose

Conversation

@ZShubhi
Copy link
Contributor

@ZShubhi ZShubhi commented Dec 1, 2025

Added button stepper

@ZShubhi ZShubhi requested a review from firefinchdev as a code owner December 1, 2025 09:50
@ZShubhi ZShubhi changed the base branch from dev to common-snippet-pros December 1, 2025 11:20
@pjinosh-zomato
Copy link

@ZShubhi can you add screenshot

* @param onIncrementFail Callback invoked when attempting to increment beyond maxCount
* @param modifier The modifier to be applied to the component
*
* Created by AI Assistant

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created by AI Assistant :-D

Comment on lines 90 to 96
SushiTextButton(
props = props,
onClick = onClick,
Modifier.fillMaxSize(),
content = content,
shouldUnderline = true
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this?

Comment on lines 74 to 86
markdown = props.markdown,
textDecoration = if (shouldUnderline) SushiTextDecoration.Underline()
else null
markdown = props.markdown
)
)
if (!props.subText.isNullOrEmpty()) {
SushiText(
SushiTextProps(
text = props.subText,
color = appliedFontColor,
type = with(SushiButtonDefaults) { getSubtextTextStyle(textType).asTextTypeSpec() },
textDecoration = if (shouldUnderline) SushiTextDecoration.Underline()
else null
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this??

* - Text: Button with only text, no background or border
* - Solid: Button with solid background color and text
* - Outline: Button with a border outline and text
* - Underline: Button with underlined text
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove?

fontColorDisabled = fontColorDisabled,
fontColorPressed = fontColorPressed,
fontColor = fontColor,
modifier = Modifier.fillMaxSize()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove?

props = props,
isDisabled = isDisabled,
isTapped = isTapped.value,
shouldUnderline = shouldUnderline,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SAA

fontColorDisabled = fontColorDisabled,
fontColorPressed = fontColorPressed,
fontColor = fontColor,
modifier = modifier,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SAA

@@ -1,2 +1,2 @@
#Mon Nov 3 13:02:40 UTC 2025
VERSION_NAME=0.0.23
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this

@Bhavesh2404 Bhavesh2404 changed the title Button stepper Button stepper and Markdown Processor FIX Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants