-
Notifications
You must be signed in to change notification settings - Fork 22
feat: artifacts #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: artifacts #52
Conversation
…active execution uses for events
…sult-aggregation-3
Summary of ChangesHello @yarolegovich, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the system's ability to manage and interact with task-related data by introducing robust artifact handling and a new streaming API for message events. The changes enable more dynamic updates and better control over task artifacts, while also improving the internal structure of message processing through refactoring. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces artifact handling and a streaming endpoint for sending messages. The code is well-structured, with logic from OnSendMessage
refactored into a reusable handleSendMessage
function, which is a good design choice. The new artifact update logic in taskupdate.Manager
is comprehensive and is accompanied by a solid set of tests. I've identified a couple of minor areas for improvement in the tests to make them more robust and maintainable.
var streamErr bool | ||
for got, gotErr := range handler.OnSendMessageStream(ctx, input) { | ||
var want a2a.Event | ||
if eventI < len(tt.agentEvents) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these assertions are refactored in another PR
Details