Skip to content

code fix for #333 #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

code fix for #333 #342

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0506bfd
code fix for #333
dhruv-bansal Aug 27, 2025
e2b2cc3
fix: prevent taskId from being sent to remote agents (fixes #333)
dhruv-bansal Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions samples/python/agents/airbnb_planner_multiagent/host_agent/routing_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,9 +253,10 @@ async def send_message(
'messageId': message_id,
},
}

if task_id:
payload['message']['taskId'] = task_id
# Don't send taskId to remote agents - let them create their own tasks
# Remote agents should create new tasks, not try to find existing unknown task IDs
# if task_id:
# payload['message']['taskId'] = task_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Rather than commenting out this code, it's preferable to remove it completely. Leaving commented-out code can lead to confusion and clutter the codebase. The version control system (Git) will preserve the history of this change, so the code can be recovered if needed in the future.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, but adding explicitly comment and commenting code for now so that it is easy for reviewer to review it once it is reviewed probably before merging on it next refactoring I will remove the commented code.


if context_id:
payload['message']['contextId'] = context_id
Expand Down