This repository was archived by the owner on Jul 6, 2025. It is now read-only.
Add shared library support and fix library install path on Linux#815
Open
musicinmybrain wants to merge 2 commits intoabumq:masterfrom
Open
Add shared library support and fix library install path on Linux#815musicinmybrain wants to merge 2 commits intoabumq:masterfrom
musicinmybrain wants to merge 2 commits intoabumq:masterfrom
Conversation
This fixes installation paths on Linux. For example, the static library is installed to /usr/lib64/ when appropriate.
Use the major version number as the SOVERSION.
Author
|
Upon further investigation, given the number of configuration preprocessor macros affecting the compilation of the I think I will try to follow other distributions’ lead in packaging this as a header-only library, where the I will leave the PR here in case it is useful anyway… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a
I have
CHANGELOG.mdREADME.mdThis PR uses the major version number as the
SOVERSION, which presumes that no ABI-breaking changes will be made without bumping the major version.I see two test failures, neither of which was introduced by this PR: