Skip to content

Conversation

LAhmos
Copy link
Contributor

@LAhmos LAhmos commented Jul 10, 2025

No description provided.

tgrogers
tgrogers previously approved these changes Jul 11, 2025
Copy link
Contributor

@tgrogers tgrogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.
@LAhmos - should I integrate this or should we kick off the PR CI again now that the app collection change has been integrated?

@LAhmos LAhmos closed this Jul 13, 2025
@LAhmos LAhmos reopened this Jul 13, 2025
tgrogers
tgrogers previously approved these changes Jul 15, 2025
Copy link
Contributor

@tgrogers tgrogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tgrogers tgrogers added this pull request to the merge queue Jul 15, 2025
@LAhmos LAhmos removed this pull request from the merge queue due to a manual request Jul 15, 2025
@LAhmos
Copy link
Contributor Author

LAhmos commented Jul 15, 2025

I forgot to update HW stats , adding them now

@LAhmos
Copy link
Contributor Author

LAhmos commented Jul 15, 2025

@tgrogers can you approve again

@LAhmos LAhmos added this pull request to the merge queue Jul 15, 2025
Merged via the queue into accel-sim:dev with commit 879dc35 Jul 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants