[document_repository] Fix swal translation coverage#10393
Open
arnav-makkar wants to merge 1 commit intoaces:mainfrom
Open
[document_repository] Fix swal translation coverage#10393arnav-makkar wants to merge 1 commit intoaces:mainfrom
arnav-makkar wants to merge 1 commit intoaces:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR fixes untranslated
document_repositoryswal dialogs by removing hardcoded English text, correcting a namespace mismatch, and localizing known backend error messages shown in popups.t(...)translations."You won't be able to revert this!"to thedocument_repositorynamespace.Duplicate category name under same parent folder.,Can not delete non-empty category) with raw-text fallback for unknown messages.fr,hi, andja(with English msgid fallback), includingDeleteand category error strings.OKconfirm button text in the affected swals.Since I don't have experience with Japanese, a strict review will be required for its translations.
Please let me know whatever changes required and I'll incorporate them.
Screenshots
Link(s) to related issue(s)