Skip to content

[document_repository] Fix swal translation coverage#10393

Open
arnav-makkar wants to merge 1 commit intoaces:mainfrom
arnav-makkar:fix/10280-swal-translation
Open

[document_repository] Fix swal translation coverage#10393
arnav-makkar wants to merge 1 commit intoaces:mainfrom
arnav-makkar:fix/10280-swal-translation

Conversation

@arnav-makkar
Copy link
Copy Markdown
Contributor

Brief summary of changes

This PR fixes untranslated document_repository swal dialogs by removing hardcoded English text, correcting a namespace mismatch, and localizing known backend error messages shown in popups.

  • Updated add-category, delete-category, edit-entry, and delete-file swals to use t(...) translations.
  • Fixed delete confirmation text lookup by switching "You won't be able to revert this!" to the document_repository namespace.
  • Added translation mapping for known backend errors (Duplicate category name under same parent folder., Can not delete non-empty category) with raw-text fallback for unknown messages.
  • Added missing translation keys and entries for fr, hi, and ja (with English msgid fallback), including Delete and category error strings.
  • Added translated OK confirm button text in the affected swals.

Since I don't have experience with Japanese, a strict review will be required for its translations.
Please let me know whatever changes required and I'll incorporate them.

Screenshots

Screenshot 2026-03-06 at 12 43 09 Screenshot 2026-03-06 at 12 43 26 Screenshot 2026-03-06 at 13 14 00 Screenshot 2026-03-06 at 13 14 47 Screenshot 2026-03-06 at 12 43 49 Screenshot 2026-03-06 at 12 44 17 Screenshot 2026-03-06 at 13 15 00

Link(s) to related issue(s)

@github-actions github-actions bot added Language: Javascript PR or issue that update Javascript code Module: document_repository PR or issue related to documen_repository module Multilingual Any tasks related to making LORIS multilingual labels Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language: Javascript PR or issue that update Javascript code Module: document_repository PR or issue related to documen_repository module Multilingual Any tasks related to making LORIS multilingual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[document_repository] Swals not translated

2 participants