[DQT] Fix visit list filtering in candidate matching#10438
Open
HenriRabalais wants to merge 3 commits intoaces:mainfrom
Open
[DQT] Fix visit list filtering in candidate matching#10438HenriRabalais wants to merge 3 commits intoaces:mainfrom
HenriRabalais wants to merge 3 commits intoaces:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where DQT filters did not apply visit list criteria when matching candidates. The
getCandidateMatches()method was not passing the$visitlistparameter tobuildQueryFromCriteria(), and the visit filtering logic inbuildQueryFromCriteria()was incorrectly adding a duplicate session table join.Changes
$visitlistparameter tobuildQueryFromCriteria()ingetCandidateMatches()methodbuildQueryFromCriteria()- the session table is already joined bygetFieldNameFromDict()when querying session-scoped fieldsTesting Instructions
Related Issues
Resolves #10435