Open
Conversation
properly removing CenterID from Pools finalizing changes updates added site filtering to shipments updating entities to include user-readable values adding specimen barcodes to pools attempts at resolving front-end container display changed filter type for containers implementing user site match permissions on entities properly removing CenterID from Pools finalizing changes updating entities to include user-readable values adding specimen barcodes to pools attempts at resolving front-end container display
* added function (aces#247) Co-authored-by: Rida Abou-Haidar <rida.abou-haidar@mcin.ca> * fixed site inheritance for batch preparation form * fixes made based on testing --------- Co-authored-by: Rida Abou-Haidar <rida.abou-haidar@mcin.ca>
…3-09-28_biobankmoduleforloris
HenriRabalais
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php/endpoint (concrete classes) → routes and breaks down the request and converts it into queryparam object to be passed down the chain.
php/controller (generic class with dependencies) → doesn’t do much for now but I can see potential uses in future, mostly passing along the request for now. For post or put though this is where the dtos get converted into entity models
php/service (concrete classes) → knows how to do everything that needs to be done for a specific type of model , including generic things like getting all instances, getting by id, getting by label, saving, deleting — but also can be extended to include things that have more specific needs.
php/provisioner (generic class with dependencies) → takes in a schema and queryparams and builds whatever query is necessary to accomplish the job using a querybuilder
php/data/schemas (concrete classes, ideally static) → is the only place where you will find any information from the database tables. Each table that is not a rel table has its own schema class that defines it.
php/model (concrete classes) → these are what we were previously referring to as a dto — after further investigation I think they are more appropriately named models since they hold a bit of internal logic, whereas a dto would basically be what gets sent to and from the front end — we can discuss.
php/factory (generic class with dependencies) → takes in a model class name and is able to instantiate models with passed dtos
php/validator (concrete classes) → loaded into the service layer to assist with validation before being passed to the dao
php/data/query → the query family of classes includes the querybuilder , queryparams and a suite of classes and enums for contructing queries. This is the only class that containers sql language strings.