Open
Conversation
Remove package-lock.json from tracking Add package-lock.json to gitignore
Author
|
@natacha-beck, any thoughts on this approach ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grunt testwas broken on modern Node.js with the following error:Fatal error: The "cb" argument must be of type function. Received undefined
The dependencies on which the grunt test depends were outdated which led to this error. I fixed that by updating those dependencies via npm:
Upgraded grunt-contrib-qunit to latest version which now uses headless Chrome instead of abandoned phantomjs.
Added qunit as a devDependency in package.json.
Updated test HTML files to reference QUnit from node_modules so now the test will always use the npm managed version.
Added
grunt-contrib-connectto serve files over HTTP for headless Chrome (required as Chrome cannot load files directly from filesystem like phantomjs).Updated Gruntfile.js to use puppeteer with no-sandbox flags for headless Chrome compatibility
Fixed a pre-existing jshint scope error in
examples/bigbrain-viewer-demo.jsthat was blocking grunt test from completingBefore

After
