optimization: zero-alloc / in-place PIPCost#61
Draft
merlinio2000 wants to merge 16 commits intodevelopfrom
Draft
optimization: zero-alloc / in-place PIPCost#61merlinio2000 wants to merge 16 commits intodevelopfrom
merlinio2000 wants to merge 16 commits intodevelopfrom
Conversation
…lt but Im scared)
Contributor
Test Results354 tests 354 ✅ 35m 7s ⏱️ Results for commit 04c7bab. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #61 +/- ##
===========================================
+ Coverage 96.26% 96.46% +0.20%
===========================================
Files 27 30 +3
Lines 3991 4359 +368
===========================================
+ Hits 3842 4205 +363
- Misses 149 154 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes ALL Allocations/Clones from the very often called PIPCost.logl
Operations are switched out for their in-place variations, pnu calculation even directly makes use of the blas cmpy operation.
Locally it seems like another 20-30% improvement.