Skip to content

optimization: zero-alloc / in-place PIPCost#61

Draft
merlinio2000 wants to merge 16 commits intodevelopfrom
feature/pipcost-zeroallocation
Draft

optimization: zero-alloc / in-place PIPCost#61
merlinio2000 wants to merge 16 commits intodevelopfrom
feature/pipcost-zeroallocation

Conversation

@merlinio2000
Copy link
Copy Markdown
Collaborator

Removes ALL Allocations/Clones from the very often called PIPCost.logl

Operations are switched out for their in-place variations, pnu calculation even directly makes use of the blas cmpy operation.

Locally it seems like another 20-30% improvement.

@github-actions
Copy link
Copy Markdown
Contributor

Test Results

354 tests   354 ✅  35m 7s ⏱️
  2 suites    0 💤
  1 files      0 ❌

Results for commit 04c7bab.

@codecov
Copy link
Copy Markdown

codecov bot commented May 30, 2025

Codecov Report

❌ Patch coverage is 99.22780% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.46%. Comparing base (c9c73d6) to head (04c7bab).
⚠️ Report is 64 commits behind head on develop.

Files with missing lines Patch % Lines
phylo/src/pip_model/mod.rs 99.20% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #61      +/-   ##
===========================================
+ Coverage    96.26%   96.46%   +0.20%     
===========================================
  Files           27       30       +3     
  Lines         3991     4359     +368     
===========================================
+ Hits          3842     4205     +363     
- Misses         149      154       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@merlinio2000 merlinio2000 marked this pull request as ready for review September 2, 2025 15:23
@merlinio2000 merlinio2000 changed the title Feature/pipcost zeroallocation optimization: zero-alloc / in-place PIPCost Sep 2, 2025
@merlinio2000 merlinio2000 marked this pull request as draft September 2, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant