refactor: remove production SVM utils, import from SDK (ACP-56)#1380
Draft
refactor: remove production SVM utils, import from SDK (ACP-56)#1380
Conversation
Delete hand-written SVM TypeScript utils (web3-v1/, web3-v2/, types/svm.ts) that have been migrated to @across-protocol/sdk/svm. Keep auto-generated assets/ and clients/ for the Codama generation pipeline. - Delete src/svm/web3-v1/, src/svm/web3-v2/, src/types/svm.ts - Remove SVM export from index.ts (no longer part of public API) - Update all test/svm/ imports to use @across-protocol/sdk - Update all scripts/svm/ imports to use @across-protocol/sdk - Move Solana deps to devDependencies (only needed for tests/scripts) - Add @across-protocol/sdk as devDependency - Remove buffer-layout peer dependency - Exclude scripts/ from tsconfig (avoids cross-package type mismatches) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
…isal/acp-74-clean-up-contracts-svm-utils
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
- Replace all @across-protocol/sdk/dist/cjs/src/svm deep paths with @across-protocol/sdk/svm subpath exports (blocked by SDK exports field) - Add tsconfig.test.json with module: es2020 + moduleResolution: bundler (base tsconfig stays commonjs for build output) - Update Anchor.toml to use tsconfig.test.json for ts-mocha - Replace deep client type imports with namespace access (SvmSpokeClient.FillRelayAsyncInput, SvmSpokeClient.DepositInput, etc.) - Sort package.json devDependencies alphabetically Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
module: es2020 caused ts-mocha to use ESM resolution which requires file extensions and breaks target/types/ imports. node16 supports subpath exports while keeping CJS require() behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete hand-written SVM TypeScript utils (web3-v1/, web3-v2/, types/svm.ts) that have been migrated to @across-protocol/sdk/svm. Keep auto-generated assets/ and clients/ for the Codama generation pipeline.