Draft
Conversation
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
…ts into faisal/option2-impl
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
fusmanii
commented
Apr 2, 2026
contracts/usdfree/OrderGateway.sol
Outdated
| } | ||
|
|
||
| bool selfSubmit = order.orderOwner == msg.sender; | ||
| if (!selfSubmit && orderOwnerFunding.funding.length == 0) revert OrderAuthRequired(); |
Contributor
Author
There was a problem hiding this comment.
this is not needed since we always want order owner funding
contracts/usdfree/OrderGateway.sol
Outdated
Comment on lines
+215
to
+219
| if (cmd & Commands.FLAG_SUBMITTER_INPUT != 0) { | ||
| input = subInputs[subIdx++]; | ||
| } else { | ||
| input = ownerInputs[ownerIdx++]; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
we need to take into account command where both user and submitter inputs are needed (e.g. off auction data)
contracts/usdfree/OrderGateway.sol
Outdated
Comment on lines
+354
to
+355
| (address adapter, bytes memory data) = abi.decode(input, (address, bytes)); | ||
| (ok, out) = adapter.delegatecall(data); |
Contributor
Author
There was a problem hiding this comment.
we need submitter data here to be used in the adapter
contracts/usdfree/OrderGateway.sol
Outdated
Comment on lines
+354
to
+355
| (address adapter, bytes memory data) = abi.decode(input, (address, bytes)); | ||
| (ok, out) = adapter.delegatecall(data); |
Contributor
Author
There was a problem hiding this comment.
the adaptor addresses need to be behind a gated mapping that can only be assigned by owner/admin
contracts/usdfree/OrderGateway.sol
Outdated
| revert InvalidCommand(op); | ||
| } | ||
| } else { | ||
| if (op == Commands.BALANCE_CHECK) { |
Contributor
Author
There was a problem hiding this comment.
we need a command to be able to do a makeCallWithBalance type of call to the executor
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.