Skip to content

fix: Do not move externals dir #3740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Do not move externals dir #3740

wants to merge 1 commit into from
+0 −4

Conversation

claytonchew
Copy link

Resolves #3634

@claytonchew claytonchew mentioned this pull request Sep 12, 2024
Closed
4 tasks
@claytonchew
Copy link
Author

@mumoshu Looks like this is in conflict with #2616

Currently we are building runner images from this repo, this change resolves '/home/runner/externals/.': No such file or directory issue. How do you suggest we proceed?

ghost
ghost reviewed Sep 13, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zmrde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu Awaiting requested review from mumoshu mumoshu is a code owner

@toast-gear toast-gear Awaiting requested review from toast-gear toast-gear is a code owner

@rentziass rentziass Awaiting requested review from rentziass rentziass is a code owner

1 more reviewer
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DIND gha-runner-scale-set: cp: cannot stat '/home/runner/externals/.': No such file or directory
1 participant
@claytonchew