Fix build error in google-cloudrun-docker.yml by adding repo id, reformat the codes #3025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a build error in the Google Cloud Run Docker deployment workflow by correcting the Docker image path format and reorganizing comments. The main issue was a missing repository name component in the Artifact Registry path.
- Adds the
REPOSITORYenvironment variable for the Artifact Registry repository name - Fixes the Docker tag format to include the repository name in the correct path structure
- Reorganizes comments for better code structure
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| - name: 'Build and Push Container' | ||
| run: |- | ||
| DOCKER_TAG="$${{ env.REGION }}-docker.pkg.dev/${{ env.PROJECT_ID }}/${{ env.SERVICE }}:${{ github.sha }}" | ||
| DOCKER_TAG="$${{ env.REGION }}-docker.pkg.dev/${{ env.PROJECT_ID }}/${{ env.REPOSITORY }}/${{ env.SERVICE }}:${{ github.sha }}" |
There was a problem hiding this comment.
There's an extra dollar sign in the DOCKER_TAG assignment. It should be DOCKER_TAG="${{ env.REGION }}-docker.pkg.dev/..." not DOCKER_TAG="$${{ env.REGION }}-docker.pkg.dev/..."
Suggested change
| DOCKER_TAG="$${{ env.REGION }}-docker.pkg.dev/${{ env.PROJECT_ID }}/${{ env.REPOSITORY }}/${{ env.SERVICE }}:${{ github.sha }}" | |
| DOCKER_TAG="${{ env.REGION }}-docker.pkg.dev/${{ env.PROJECT_ID }}/${{ env.REPOSITORY }}/${{ env.SERVICE }}:${{ github.sha }}" |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
This error has been fixed in #3024
RamsesAupart
approved these changes
Aug 19, 2025
RamsesAupart
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original codes will result in an error
Pushes should be of the form docker push HOST-NAME/PROJECT-ID/REPOSITORY/IMAGE. The correct format for the path is<region>-docker.pkg.dev/<project-id>/<repository-name>/<image-name>:<tag>. The previous version forgot to add<repository-name>. Update to fix this bug.Also change the comments to the correct location.