incremented versions for gems to rails 6 ruby 2.7.0 and mongo 7#153
incremented versions for gems to rails 6 ruby 2.7.0 and mongo 7#153jesusalc wants to merge 15 commits intoactiveadmin:masterfrom
Conversation
…rsion >= 2.5.0, which is incompatible with the current version, ruby 2.4
…evelop production
grzegorz-jakubiak
left a comment
grzegorz-jakubiak
left a comment
There was a problem hiding this comment.
@jesusalc just remove 2.4 from .travis.yml its support ends in march anyways
|
I don't understand what this PR is trying to achieve, there's to many unrelated changes in here. |
Have tried to use activeadmin-mongoid with Ruby 2.6.5 > MongoId 7 and Rails 6 > ? |
It looks like there's some de-linting going on, I'm definitely OK with that. |
deivid-rodriguez
left a comment
deivid-rodriguez
left a comment
There was a problem hiding this comment.
Added a few comments.
| gem.license = 'MIT' | ||
|
|
||
| gem.required_ruby_version = '>= 2.4' | ||
| gem.required_ruby_version = '>= 2.5' |
activeadmin-mongoid.gemspec
Outdated
| gem.add_runtime_dependency 'mongoid', '>= 6.0', '< 8.a' | ||
| gem.add_runtime_dependency 'activeadmin', '>= 1.4.3' | ||
| gem.add_runtime_dependency 'mongoid', '>= 6.0', '< 8.a' | ||
| gem.add_runtime_dependency 'activeadmin', '>= 1.4.3', '<= 2.6.0' |
|
|
||
| gem 'ransack-mongoid', git: 'https://github.com/activerecord-hackery/ransack-mongoid' | ||
| # gem 'ransack-mongoid', git: 'https://github.com/activerecord-hackery/ransack-mongoid' | ||
| gem 'ransack-mongoid', github: 'jesusalc/ransack-mongoid', branch: 'rails-6-mongoid-7-ruby-2-7-0' |
There was a problem hiding this comment.
Should we first propose these changes to ransack-mongoid and discuss them there?
There was a problem hiding this comment.
@jesusalc could you open a PR to ransack-mongoid? That's actually a better idea 😉
| gem 'ransack-mongoid', github: 'jesusalc/ransack-mongoid', branch: 'rails-6-mongoid-7-ruby-2-7-0' | ||
|
|
||
| gem 'rails', '>= 5.2', '< 6.1' | ||
| gem 'webpacker' |
There was a problem hiding this comment.
I missed that as well
|
I did
…On Wed 12. Feb 2020 at 09:45, Grzegorz Jakubiak ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Gemfile
<#153 (comment)>
:
> @@ -2,9 +2,11 @@ source 'https://rubygems.org'
gemspec
-gem 'ransack-mongoid', git: 'https://github.com/activerecord-hackery/ransack-mongoid'
+# gem 'ransack-mongoid', git: 'https://github.com/activerecord-hackery/ransack-mongoid'
+gem 'ransack-mongoid', github: 'jesusalc/ransack-mongoid', branch: 'rails-6-mongoid-7-ruby-2-7-0'
@jesusalc <https://github.com/jesusalc> could you open a PR to
ransack-mongoid? That's actually a better idea 😉
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#153?email_source=notifications&email_token=AAK7CTEE3XCMMB26Q32AHRTRCOZMFA5CNFSM4KOI47M2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCVFYQYQ#discussion_r378107900>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAK7CTDGSP5BNLPKQR3H7CDRCOZMFANCNFSM4KOI47MQ>
.
|
4 participants
M Gemfile
M Gemfile.lock
M activeadmin-mongoid.gemspec