Skip to content

fix: license check being rate-limited#149

Merged
alfredolopezzz merged 4 commits intomainfrom
run-license-check-on-mod-changes
Oct 2, 2025
Merged

fix: license check being rate-limited#149
alfredolopezzz merged 4 commits intomainfrom
run-license-check-on-mod-changes

Conversation

@alfredolopezzz
Copy link
Copy Markdown
Contributor

@alfredolopezzz alfredolopezzz commented Oct 2, 2025

Context

License test is currently failing in CI:

=== RUN   TestLicenses
    license_test.go:40: 
        	Error Trace:	/home/runner/work/noe/noe/license_test.go:40
        	Error:      	Received unexpected error:
        	            	errors: [making req to https://pkg.go.dev/github.com/temoto/robotstxt: Too Many Requests]
        	Test:       	TestLicenses
--- FAIL: TestLicenses (5.34s)
FAIL
FAIL	github.com/adevinta/noe	5.353s

What this PR changes

  • runs license check only when there are changes to the go mod file
  • adds retry logic to the license test

Validations

PoW:
image
https://github.com/adevinta/noe/actions/runs/18192096386/job/51789267369

Related Issues

Checklist

  • Unit tests, if necessary, have been added or updated to cover the changes made.
  • Documentation (e.g. README, API docs) has been updated to reflect the changes made.

This reverts commit 803f9eb.
@alfredolopezzz alfredolopezzz added this pull request to the merge queue Oct 2, 2025
Merged via the queue into main with commit 12aacec Oct 2, 2025
3 checks passed
@alfredolopezzz alfredolopezzz deleted the run-license-check-on-mod-changes branch October 3, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants