Skip to content

Conversation

@rozbrajaczpoziomow
Copy link

@Mrgaton
Copy link

Mrgaton commented Sep 28, 2024

I don't see this as a good idea, if oneko would move as same as the page content at the same velocity and position yeah but you can't control that.

@st4rburn
Copy link
Contributor

You can do this by changing nekoEl.style.position = "fixed"; to nekoEl.style.position = "absolute"; in init() if you wanted to do it yourself, but not sure if this is seen as an issue by the creator or not because there's definitely arguments for both ways and the way it is may have been a design choice c:

@Mrgaton
Copy link

Mrgaton commented Sep 28, 2024

You can do this by changing nekoEl.style.position = "fixed"; to nekoEl.style.position = "absolute"; in init() if you wanted to do it yourself, but not sure if this is seen as an issue by the creator or not because there's definitely arguments for both ways and the way it is may have been a design choice c:

can you add it to your pull request via an option too?

@rozbrajaczpoziomow
Copy link
Author

rozbrajaczpoziomow commented Sep 28, 2024

Both work and look differently, so, ignoring the fact I didn't know position absolute would do that, let's just say it was a design choice.
I also don't think position absolute would work for scrolling smaller parts of the page (i.e. not the whole page, some chatbox or whatnot)

@adryd325
Copy link
Owner

this is implementable with CSS for users which have a preference, or users can just change the script themselves

#oneko {
    position: absolute !important;
}

Alternatively you could reimplement as an option using data attributes on the script tag like in #31

In the repo I'm gonna leave the default as it is.

@rozbrajaczpoziomow
Copy link
Author

sounds fair enough, thanks ;p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants