Clean up code syntax, make Oneko unselectable #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think they're active on this project anymore, but this was useful to me - I wouldn't have thought of that. Thank you! |
I still maintain this project, However running your own formatter on the codebase is bad practice as it creates a massive commit with no meaningful changes; and formatter preferences are often opinionated. Disabling selection on neko should be a separate PR that doesn't touch formatting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cleaned up the syntax a bit so it's more readable. I also noticed an oddity of Oneko "selecting" a blank text box whenever it is double clicked while I was testing a petting function. so, I simply changed it's user-select property so it can no longer be selected like text.
I, however have not made any changes to the IE6 file because I've never worked with pre-IE8 JS before so I won't bother to avoid creating any issues in the future.
(this is my first pull request yay!!!)