Authors are sometimes not getting loaded on abstract pages#2359
Merged
thostetler merged 4 commits intoadsabs:masterfrom Oct 21, 2025
Merged
Conversation
…page - Detect truncated author data from results widget's minAuthorsPerResult setting - Automatically fetch complete author data when displaying abstract - Prevent showing (-) placeholders for missing author affiliations - Extend fetchAffiliations to also handle complete author data fetching - Add needsCompleteAuthorData helper to detect incomplete data
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where authors were not always loading on abstract pages when field limiting was used, and adds lazy loading functionality for the "and xxx more" author link on results pages.
Key Changes:
- Detects when author/affiliation data is truncated and triggers automatic refetch on abstract pages
- Implements expand/collapse functionality for author lists in results widget with lazy loading
- Updates templates to show clickable "and xxx more" link when partial author data is available
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/js/widgets/results/widget.js | Adds expand/collapse event handlers and API request logic for lazy loading full author lists |
| src/js/widgets/list_of_things/templates/item-template.html | Updates template to conditionally show expand/collapse links and loading states for author lists |
| src/js/widgets/list_of_things/item_view.js | Adds model event listeners to trigger re-rendering when author expansion state changes |
| src/js/widgets/abstract/widget.js | Implements detection and automatic fetching of complete author data when truncation is detected |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
shinyichen
approved these changes
Oct 21, 2025
thostetler
deleted the
SCIX-664-bbb-authors-don-t-always-show-properly-on-abstrac
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and xxx moreto show all authors, but it now does so in a lazy way