Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR represents the work done to include the SciX ID in the output of the service. In order to achieve this goal, the following was done
config.pyto include the Solr fieldscix_idinREFERENCE_SERVICE_QUERY_FIELDS_SOLRso that this field is always present when results (i.e. potential matches) are retrieved from Solr/textor/xmlendpoint is used to submit reference data, the actual processing always ends up in the function solve_for_fields. Here the contents of the Solr fieldscix_idneed to be passed on when creating theSolutioninstance sent backscix_idattribute. The string representation of class instances__str__needs to be updated to include the value of this attribute. This is because the result of the matching process is passed on as str(solve_reference(Hypotheses(parsed_ref))) (theresolve_referencereturns aSolutioninstance).Solutioninstance and creating a JSON structure with the results of the matching