Feat: Add setting for date format #1599
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichwall
reviewed
Jun 4, 2025
| dateFormatOptionItems() { | ||
| return [ | ||
| { | ||
| text: 'MM/DD/YYYY', |
There was a problem hiding this comment.
These strings should be able to be localized
There was a problem hiding this comment.
From what I can see, it doesn't look like that string is being localized on the server side either.
Do you know how it should be done? I'm happy to update it if there's a better way.
Rdkang
commented
Jun 4, 2025
| // return !this.isMissing && !this.isInvalid && !this.isStreaming && (this.numTracks || this.recentEpisode) | ||
| }, | ||
| dateFormat() { | ||
| return this.store.state.deviceData?.deviceSettings?.dateFormat || 'MM/dd/yyyy' |
There was a problem hiding this comment.
Is this the right way to get the dateFormat setting? @nichwall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary
A setting to choose the date format to use in the UI.
I implemented the same functionality that exists on the audiobookshelf server settings.
Which issue is fixed?
Fixes #637
Pull Request Type
Android and IOS
mainly affects the frontend
In-depth Description
Allows the user to choose the date format for the app to display the
added time, birth time, modified time and finished time
How have you tested this?
Tested using Android 15 device emulator and Google Pixel 7.
Screenshots
settings overview
settings options
book with added date
book with finished date