Accessibility Improvements #1620
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improving labels and keyboard navigation in appbar - Add list semantics to shelf view (audiobooks only for now) - Improving keyboard navigation and labeling for author view - Improving labeling and keyboard navigation for book card (more work needed for podcasts) - Adding labels to bookshelf nav bar - Adding label for connection indicator - More robust labeling method for the search field
- Accessibility labels for all controls excluding the modals - Accessibility roles for all controls excluding the modals - Keyboard events for all controls - Focus management for opening and closing the fullscreen player
|
There are still improvements to be done. But I think this is a good place for the first PR. I didn't want the changes to get too big to keep track of |
nichwall
approved these changes
Jul 12, 2025
|
I see conflicts with 2 files but it looks like changes that were made have introduced hardcoded strings into the aria-label attributes. Shouldn't we want all strings to come from resources to support translations? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary
Accessibility Improvements for users with disabilities. The only visual change is adding a visible focus indicator to the author cards.
Which issue is fixed?
Pull Request Type
In-depth Description
The app contains lots of unlabeled controls and controls that do not have roles. This should address the issues listed above, but the whole app needs some work to make it accessible. This app can be particularly appealing to screen reader users since audiobooks are generally favored over Braille books.
How have you tested this?
Tested with mobile screen readers, inspected the output HTML, and used the Android Accessibility Inspector.
Screenshots
This screenshot is the only visible front end change that I made. It is a focus indicator for the author cards which is necessary for users that might be using a bluetooth keyboard with their device.
