add search inside epub files. #1323 #1667
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary
add the search functionality inside the epub reader on the official android client.
Which issue is fixed?
it solves this issue: #1323
Pull Request Type
I only tested it on android, but I guess it must work on IOS because of capacitor.
In-depth Description
you can click on the search icon, enter a query in the search modal and then select among the matches. there are also, two more buttons as part of the controls: a next and previous occurrence buttons. the search query gets highlighted. the modal remembers the last search query per book.
How have you tested this?
opened multiple epub books from my library, and tested all the new features again and again untill I was satisfied with the results.
tested it on my physical Android 10 phone and a virtual Android 14 one.
Screenshots