Skip to content

Support RTL languages#120

Open
MaxWasserthal wants to merge 2 commits intoaheze:mainfrom
nextbike:fix/support-rtl-layouts
Open

Support RTL languages#120
MaxWasserthal wants to merge 2 commits intoaheze:mainfrom
nextbike:fix/support-rtl-layouts

Conversation

@MaxWasserthal
Copy link

Ideation

  • Popover views do not adjust for right-to-left layouts
  • Changing the device layout flips all elements but the popovers are always positioned using the physical left & right.

Changes

  • Add view's device orientation to the Popovers Context
  • Adjust positioning calculations
    • Instead of defining static left / right sides use leading / trailing sides based on device orientation
    • Invert horizontal paddings and offsets if applicable

Testing

  • Test these changes by changing the schemes AppLanguage to Right-to-Left Pseudolanguage
  • The popovers using absolute positioning should be anchored from the opposite side
  • Rubberbanding should not be affected by the change in layout orientation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant