-
Notifications
You must be signed in to change notification settings - Fork 688
refactor: consolidate Observability files (e.g. OTEL docker-compose, md files) #4173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
keivenchang
merged 19 commits into
main
from
keivenchang/DIS-980__consolidate-OTEL-docker-compose-files
Nov 10, 2025
Merged
Changes from 5 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
65c4f5b
refactor: consolidate observability stack into unified docker-observa…
keivenchang 3b63e21
Reorganize observability configs and improve tracing docs
keivenchang 0b71cf8
Standardize observability docs structure and improve clarity
keivenchang 9cd7cf1
Add new observability docs to toctree
keivenchang 8a80eee
Remove Optional Observability Stack section from README
keivenchang b6398ef
Fix documentation issues from observability reorganization
keivenchang ef2e529
Fix broken link anchor in Python metrics README
keivenchang 4c1e061
Fix broken link in Python metrics examples README
keivenchang de7a07a
Simplify Grafana dashboard names and improve logging docs
keivenchang 67541d0
Reorganize and standardize observability documentation
keivenchang 6cac372
logging to not mention OTEL
keivenchang f220b9b
Merge branch 'main' into keivenchang/DIS-980__consolidate-OTEL-docker…
keivenchang 8eabedd
Fix race condition in test_http_service
keivenchang ac5a72c
Clarify logging terminology and fix copyright headers
keivenchang 24a15fd
add back README.md references, and removed unused podmonitor files
keivenchang 1156f7c
Merge branch 'main' into keivenchang/DIS-980__consolidate-OTEL-docker…
keivenchang d53444c
Remove remaining DYN_SYSTEM_ENABLED variables
keivenchang db37a76
cargo fmt
keivenchang c00d419
Add dynamomodel-guide.md to hidden toctree
keivenchang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,137 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
keivenchang marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| # Observability stack for Dynamo: metrics, tracing, and visualization. | ||
| # Requires deploy/docker-compose.yml to be running for NATS and etcd connectivity. | ||
| # | ||
| # Usage: | ||
| # docker compose -f deploy/docker-observability.yml up -d | ||
|
|
||
| version: '3.8' | ||
|
|
||
| networks: | ||
| server: | ||
| external: true | ||
| name: deploy_server | ||
|
|
||
| volumes: | ||
| grafana-data: | ||
| tempo-data: | ||
|
|
||
| services: | ||
| # DCGM stands for Data Center GPU Manager: https://developer.nvidia.com/dcgm | ||
| # dcgm-exporter is a tool from NVIDIA that exposes DCGM metrics in Prometheus format. | ||
| dcgm-exporter: | ||
| image: nvidia/dcgm-exporter:4.2.3-4.1.3-ubi9 | ||
| ports: | ||
| # Expose dcgm-exporter on port 9401 both inside and outside the container | ||
| # to avoid conflicts with other dcgm-exporter instances in distributed environments. | ||
| # To access DCGM metrics: | ||
| # Outside the container: curl http://localhost:9401/metrics (or the host IP) | ||
| # Inside the container (container-to-container): curl http://dcgm-exporter:9401/metrics | ||
| - 9401:9401 | ||
| cap_add: | ||
| - SYS_ADMIN | ||
| deploy: | ||
| resources: | ||
| reservations: | ||
| devices: | ||
| - driver: nvidia | ||
| count: all | ||
| capabilities: [gpu] | ||
| environment: | ||
| # dcgm uses NVIDIA_VISIBLE_DEVICES variable but normally it is CUDA_VISIBLE_DEVICES | ||
| - NVIDIA_VISIBLE_DEVICES=${CUDA_VISIBLE_DEVICES:-all} | ||
| - DCGM_EXPORTER_LISTEN=:9401 | ||
| runtime: nvidia # Specify the NVIDIA runtime | ||
| networks: | ||
| - server | ||
|
|
||
| # The exporter translates from /varz and other stats to Prometheus metrics | ||
| nats-prometheus-exporter: | ||
| image: natsio/prometheus-nats-exporter:0.17.3 | ||
| command: ["-varz", "-connz", "-routez", "-subz", "-gatewayz", "-leafz", "-jsz=all", "http://nats-server:8222"] | ||
| ports: | ||
| - 7777:7777 | ||
| networks: | ||
| - server | ||
|
|
||
| # To access Prometheus from another machine, you may need to disable te firewall on your host. On Ubuntu: | ||
| # sudo ufw allow 9090/tcp | ||
| prometheus: | ||
| image: prom/prometheus:v3.4.1 | ||
| container_name: prometheus | ||
| volumes: | ||
| - ./observability/prometheus.yml:/etc/prometheus/prometheus.yml | ||
| command: | ||
| - '--config.file=/etc/prometheus/prometheus.yml' | ||
| - '--storage.tsdb.path=/prometheus' | ||
| # These provide the web console functionality | ||
| - '--web.console.libraries=/etc/prometheus/console_libraries' | ||
| - '--web.console.templates=/etc/prometheus/consoles' | ||
| - '--web.enable-lifecycle' | ||
| restart: unless-stopped | ||
| # Example to pull from the /query endpoint: | ||
| # {__name__=~"DCGM.*", job="dcgm-exporter"} | ||
| ports: | ||
| - "9090:9090" | ||
| networks: | ||
| - server | ||
| extra_hosts: | ||
| - "host.docker.internal:host-gateway" | ||
| depends_on: | ||
| - dcgm-exporter | ||
| - nats-prometheus-exporter | ||
|
|
||
| # Tempo - Distributed tracing backend | ||
| tempo: | ||
| image: grafana/tempo:2.8.2 | ||
| command: [ "-config.file=/etc/tempo.yaml" ] | ||
| user: root | ||
| volumes: | ||
| - ./observability/tempo.yaml:/etc/tempo.yaml | ||
| - tempo-data:/tmp/tempo | ||
| ports: | ||
| - "3200:3200" # Tempo HTTP | ||
| - "4317:4317" # OTLP gRPC receiver (accessible from host) | ||
| - "4318:4318" # OTLP HTTP receiver (accessible from host) | ||
| networks: | ||
| - server | ||
|
|
||
| # Grafana - Visualization and dashboards | ||
| # Supports both Prometheus (metrics) and Tempo (tracing) datasources | ||
| # Default credentials: dynamo/dynamo | ||
| # To access Grafana from another machine, you may need to disable te firewall on your host. On Ubuntu: | ||
| # sudo ufw allow 3000/tcp | ||
| grafana: | ||
| image: grafana/grafana:12.2.0 | ||
| container_name: grafana | ||
| volumes: | ||
| - grafana-data:/var/lib/grafana | ||
| - ./observability/grafana_dashboards:/etc/grafana/provisioning/dashboards | ||
| - ./observability/grafana-datasources.yml:/etc/grafana/provisioning/datasources/prometheus.yml | ||
| - ./observability/tempo-datasource.yml:/etc/grafana/provisioning/datasources/tempo.yml | ||
| environment: | ||
| - GF_SERVER_HTTP_PORT=3000 | ||
| # do not make it admin/admin, because you will be prompted to change the password every time | ||
| - GF_SECURITY_ADMIN_USER=dynamo | ||
| - GF_SECURITY_ADMIN_PASSWORD=dynamo | ||
| - GF_USERS_ALLOW_SIGN_UP=false | ||
| - GF_FEATURE_TOGGLES_ENABLE=traceqlEditor | ||
| - GF_INSTALL_PLUGINS=grafana-piechart-panel | ||
| # Default min interval is 5s, but can be configured lower | ||
| - GF_DASHBOARDS_MIN_REFRESH_INTERVAL=2s | ||
| # Disable password change requirement | ||
| - GF_SECURITY_DISABLE_INITIAL_ADMIN_CREATION=false | ||
| - GF_SECURITY_ADMIN_PASSWORD_POLICY=false | ||
| - GF_AUTH_DISABLE_LOGIN_FORM=false | ||
| - GF_AUTH_DISABLE_SIGNOUT_MENU=false | ||
| restart: unless-stopped | ||
| ports: | ||
| - "3000:3000" | ||
| networks: | ||
| - server | ||
| depends_on: | ||
| - prometheus | ||
| - tempo | ||
|
|
||
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
deploy/logging/README.md → deploy/observability/k8s/logging/README.md
keivenchang marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| # Dynamo Logging on Kubernetes | ||
|
|
||
| For detailed documentation on collecting and visualizing logs on Kubernetes, see [docs/kubernetes/observability/logging.md](../../docs/kubernetes/observability/logging.md). | ||
| For detailed documentation on collecting and visualizing logs on Kubernetes, see [docs/kubernetes/observability/logging.md](../../../../docs/kubernetes/observability/logging.md). |
nnshah1 marked this conversation as resolved.
Show resolved
Hide resolved
|
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.