Add SMTP constructor keyword 'stream_reader_class', default asyncio.S…#286
Open
davidmcnabnz wants to merge 2 commits intoaio-libs:masterfrom
Open
Add SMTP constructor keyword 'stream_reader_class', default asyncio.S…#286davidmcnabnz wants to merge 2 commits intoaio-libs:masterfrom
davidmcnabnz wants to merge 2 commits intoaio-libs:masterfrom
Conversation
added 2 commits
October 19, 2021 19:06
…treamReader, allowing user subclass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…treamReader, allowing user subclass
What do these changes do?
Allows a caller to specify their own subclass of asyncio.StreamReader
Are there changes in behavior for the user?
This will not affect behaviour for users who do not provide a 'stream_reader_class' SMTP constructor keyword.
But for callers who do provide their own subclass, this gives the
ability to override methods of asyncio.StreamReader, such as .readuntil()
Related issue number
#285
Fixes #285
Checklist
{py36,py37,py38,py39}-{nocov,cov,diffcov}, qa, docs{py36,py37,py38,py39}-{nocov,cov,diffcov}{py36,py37,py38,py39}-{nocov,cov,diffcov}, pypy3-{nocov,cov}, qa, docs{py36,pypy3}-{nocov,cov,diffcov}, qapy36-{nocov,cov,diffcov}, qa, docsNEWS.rstfile