Use trustme for test TLS certificate and key#552
Use trustme for test TLS certificate and key#552rominf wants to merge 1 commit intoaio-libs:masterfrom
Conversation
|
It's unclear to me what the pytest-asyncio plug-in has to do with TLS certificates or why it needs to be removed. Either way, it's best to avoid mixing up unrelated changes. |
9c2a07d to
23af110
Compare
|
I tried to add workaround for installing Hence, #555 should be reviewed and merged first. |
|
I'm pretty sure cryptography has older published wheels that would be compatible. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #552 +/- ##
==========================================
+ Coverage 97.78% 97.82% +0.03%
==========================================
Files 23 23
Lines 5697 5709 +12
Branches 764 770 +6
==========================================
+ Hits 5571 5585 +14
+ Misses 80 78 -2
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
You are right, |
|
It's possible to use env markers and only install the older version under PyPy but not others. |
With the current approach TLS certificate and key are hardcoded in separate files and distributed as part of wheels. This is unnecessary for end users of the package, also this brings difficulties while supporting Python 3.13, see: aio-libs#473 Use trustme for generating TLS certificate and key on the fly, as it is done in other aio-libs packages. Initially proposed in: aio-libs#473 (comment)
|
I had to read PEP 496, I didn't know about |
|
It was rejected and superseded by PEP 508. |
What do these changes do?
Use trustme for test TLS certificate and key
With the current approach TLS certificate and key are hardcoded in separate files and distributed as part of wheels. This is unnecessary for end users of the package, also this brings difficulties while supporting Python 3.13, see: #473
Use trustme for generating TLS certificate and key on the fly, as it is done in other aio-libs packages.
Initially proposed in: #473 (comment)
Are there changes in behavior for the user?
Wheels no longer include test TLS certificate and key.
Related issue number
Checklist
py311-cov(after merging Removepytest-asynciotraces #554)NEWS.rstfile [not worthy for NEWS.rst]