Skip to content

Conversation

@saifsafsf
Copy link

What

volumes: label in spec.template.spec.containers field throws the following warning if no extraVolumes are passed.
warnings.go:70] unknown field "spec.template.spec.containers[0].volumes

How

Placing the volumes: label inside the if condition helps avoid the aforementioned warning when no extraVolumes are passed.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@CLAassistant
Copy link

CLAassistant commented May 4, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 24 committers have signed the CLA.

✅ cgardens
✅ joeykmh
❌ teallarson
❌ jdpgrailsdev
❌ cjkenned
❌ JonsSpaghetti
❌ dbgold17
❌ bgroff
❌ dizel852
❌ tryangul
❌ slate71
❌ pnilan
❌ perangel
❌ pedroslopez
❌ clnoll
❌ girarda
❌ letiescanciano
❌ bazarnov
❌ wennergr
❌ abuchanan-airbyte
❌ lmossman
❌ gosusnp
❌ octavia-squidington-iii
❌ benmoriceau
You have signed the CLA already but the status is still pending? Let us recheck it.

saifsafsf and others added 27 commits May 5, 2025 03:17
benmoriceau and others added 23 commits May 5, 2025 03:29
@saifsafsf
Copy link
Author

Replaced with #404

@saifsafsf saifsafsf closed this May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.