🐛 Fix parsing docker image when the full image name contains registry port

[ogusak]

What

The existing docker image parsing assumes only a single : delimiter in the image name which is used to denote image tag in the image name. However, in a general case, the full image name may contain registry host with port number, which is also delimited with :.

See full description here

How

Parse full image name into version and image name based on the last occurrence of : delimiter

Can this PR be safely reverted and rolled back?

• YES 💚
• NO ❌

[CLAassistant]

All committers have signed the CLA.

[github-actions]

Your branch is not currently up-to-date with main. Please update your branch before attempting to snapshot your PR.

[marcosmarxm]

Thanks for the fix @ogusak I'm gonna ask the platform team to review this during the week.

[ogusak]

@marcosmarxm - could you check with your team please on reviewing this PR - thanks!

[ogusak]

Hi @marcosmarxm - could someone take a look at this PR. Thanks!

[marcosmarxm]

Can someone from @airbytehq/platform-compose / @airbytehq/platform-move take a look into this small contribution?

[marcosmarxm]

Sorry the delay @ogusak. @jdpgrailsdev can you help reviewing this contribution, thanks!

[jdpgrailsdev]

[ogusak]

Thanks a lot for taking a look, @jdpgrailsdev !

[jdpgrailsdev]

/create-oss-pr

[jdpgrailsdev]

@ogusak I'm not sure why the CI actions didn't catch this, but there appears to be a failing test in this PR:

ConnectorApmSupportHelperTest > testExtractAirbyteVersionFromBlankImageName() FAILED
    java.lang.NullPointerException: Cannot invoke "String.lastIndexOf(String)" because "image" is null
        at io.airbyte.workers.helper.ConnectorApmSupportHelper.getImageName(ConnectorApmSupportHelper.java:77)
        at io.airbyte.workers.helper.ConnectorApmSupportHelperTest.testExtractAirbyteVersionFromBlankImageName(ConnectorApmSupportHelperTest.java:49)

[ogusak]

@jdpgrailsdev - thanks for surfacing that error! Fixed it in the latest commit where I restored the original check for null/empty image name in ConnectorApmSupportHelper.

[jdpgrailsdev]

/create-oss-pr

[jdpgrailsdev]

@ogusak This change has been merged into our internal repo and should shortly be replicated to this repo. It will be included in the next release. Let me know if you have any questions. Thanks again for the submission.

[ogusak]

Thanks for letting me know, @jdpgrailsdev! Looking forward to deploying the new Airbyte version with the fix!

[jdpgrailsdev]

Closing, as this has been merged internally and replicated to this repository.

[jdpgrailsdev]

@ogusak Release v0.64.7 contains this fix.

[ogusak]

Thank a lot, @jdpgrailsdev !