feat: mark more fields linkable #664
Conversation
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@07-18-mark_more_fields_linkable#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch 07-18-mark_more_fields_linkableHelpful ResourcesPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
lmossman
force-pushed
the
07-18-mark_more_fields_linkable
branch
from
b311858 to
49e65f3
Compare
lmossman
force-pushed
the
07-18-mark_more_fields_linkable
branch
2 times, most recently
from
2cef81d to
3f09ed6
Compare
lmossman
force-pushed
the
07-18-mark_more_fields_linkable
branch
from
3f09ed6 to
27a4cec
Compare
lmossman
force-pushed
the
07-18-mark_more_fields_linkable
branch
2 times, most recently
from
750b4fc to
896ad5e
Compare
lmossman
changed the base branch from
07-17-update_descriptions_defaults_and_examples_of_complex_fields
to
graphite-base/664
lmossman
force-pushed
the
graphite-base/664
branch
from
683b60b to
d3d94df
Compare
lmossman
force-pushed
the
07-18-mark_more_fields_linkable
branch
from
896ad5e to
1c4901b
Compare
lmossman
force-pushed
the
07-18-mark_more_fields_linkable
branch
from
1c4901b to
c52fc61
Compare
📝 WalkthroughWalkthroughThe schema file for declarative components was updated to add a Changes
Suggested labels
Suggested reviewers
Would you like to highlight these new 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
airbyte_cdk/sources/declarative/declarative_component_schema.yaml (1)
2132-2136: HTTP requester pieces made linkable – consider deprecated siblings?
request_parameters,request_headers,request_body, anderror_handlerare now linkable – great.
One open question: the deprecatedrequest_body_data/request_body_jsonfields are still visible in some manifests. Should they also get the flag for parity, or do we intentionally leave them out to nudge users to the new field – wdyt?Also applies to: 2155-2159, 2215-2219, 2229-2233
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
airbyte_cdk/sources/declarative/declarative_component_schema.yaml(9 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: ChristoGrab
PR: airbytehq/airbyte-python-cdk#58
File: airbyte_cdk/sources/declarative/yaml_declarative_source.py:0-0
Timestamp: 2024-11-18T23:40:06.391Z
Learning: When modifying the `YamlDeclarativeSource` class in `airbyte_cdk/sources/declarative/yaml_declarative_source.py`, avoid introducing breaking changes like altering method signatures within the scope of unrelated PRs. Such changes should be addressed separately to minimize impact on existing implementations.
airbyte_cdk/sources/declarative/declarative_component_schema.yaml (4)
undefined
<retrieved_learning>
Learnt from: ChristoGrab
PR: #58
File: airbyte_cdk/sources/declarative/yaml_declarative_source.py:0-0
Timestamp: 2024-11-18T23:40:06.391Z
Learning: When modifying the YamlDeclarativeSource class in airbyte_cdk/sources/declarative/yaml_declarative_source.py, avoid introducing breaking changes like altering method signatures within the scope of unrelated PRs. Such changes should be addressed separately to minimize impact on existing implementations.
</retrieved_learning>
<retrieved_learning>
Learnt from: pnilan
PR: airbytehq/airbyte-python-cdk#0
File: :0-0
Timestamp: 2024-12-11T16:34:46.319Z
Learning: In the airbytehq/airbyte-python-cdk repository, the declarative_component_schema.py file is auto-generated from declarative_component_schema.yaml and should be ignored in the recommended reviewing order.
</retrieved_learning>
<retrieved_learning>
Learnt from: aaronsteers
PR: #58
File: airbyte_cdk/cli/source_declarative_manifest/_run.py:62-65
Timestamp: 2024-11-15T01:04:21.272Z
Learning: The files in airbyte_cdk/cli/source_declarative_manifest/, including _run.py, are imported from another repository, and changes to these files should be minimized or avoided when possible to maintain consistency.
</retrieved_learning>
<retrieved_learning>
Learnt from: aaronsteers
PR: #58
File: airbyte_cdk/cli/source_declarative_manifest/spec.json:9-15
Timestamp: 2024-11-15T00:59:08.154Z
Learning: When code in airbyte_cdk/cli/source_declarative_manifest/ is being imported from another repository, avoid suggesting modifications to it during the import process.
</retrieved_learning>
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Check: source-pokeapi
- GitHub Check: Check: source-intercom
- GitHub Check: Check: source-hardcoded-records
- GitHub Check: Check: source-shopify
- GitHub Check: Pytest (Fast)
- GitHub Check: Pytest (All, Python 3.11, Ubuntu)
- GitHub Check: Pytest (All, Python 3.10, Ubuntu)
- GitHub Check: SDM Docker Image Build
🔇 Additional comments (7)
airbyte_cdk/sources/declarative/declarative_component_schema.yaml (7)
1512-1516: Incremental sync now linkable – looks goodThe extra
linkable: trueflag here will let Builder keep different streams in-sync – no concerns on the YAML itself.
1545-1549: Transformations marked linkable – nice catchThis unlocks some handy UX in the UI, LGTM.
1569-1573: File-uploader linkable flag addedLooks right and indentation is correct.
3670-3673: Record-selector linkable – 👍
3674-3677: Paginator linkable – 👍
3684-3689: Partition-router linkable – 👍
1-10: Don’t forget to re-generate the Python artefact
declarative_component_schema.pyis auto-generated from this YAML. After merging, can we run the generation script (ormake generate-schemas) so the Python copy stays in sync – wdyt?
This PR marks more fields in the declarative component schema with
linkable: true, which allows those fields to be "linked" together in the Builder UI, which means changing that field in one stream will also change it in any other streams that have enabled linking for that field.Summary by CodeRabbit