fix(clickhouse-dest): feature complete for speed mode #66562
Conversation
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
|
Note Detected that there are differences in the Gradle dependencies. |
| core = 'load' | ||
| toolkits = ['load-db'] | ||
| cdk = '0.1.20' | ||
| cdk = 'local' |
There was a problem hiding this comment.
Did you mean to commit this change?
There was a problem hiding this comment.
Yeah since the PR is built on top of this, I need it to be local otherwise the the tests would fail
There was a problem hiding this comment.
Let's make sure to pin this before merge
|
|
||
| private fun isValidVersionColumnType(airbyteType: AirbyteType): Boolean { | ||
| // Must be of an integer type or of type Date/DateTime/DateTime64 | ||
| val validTypes = |
There was a problem hiding this comment.
Consider making this a constant/file level field to avoid creating it each time this method is called.
# Conflicts: # airbyte-integrations/connectors/destination-clickhouse/build.gradle
|
This reverts commit 705c71e.
| @Named("inputStreams") | ||
| @Singleton | ||
| fun stdInStreams() = ConnectorInputStreams(listOf(System.`in`)) | ||
| fun stdInStreams(): List<InputStream> = listOf(System.`in`) |
There was a problem hiding this comment.
We need ConnectorInputStreams to avoid issues with micronaut injection
Issue : https://github.com/airbytehq/airbyte-internal-issues/issues/14256 and https://github.com/airbytehq/airbyte-internal-issues/issues/14466