Skip to content

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Sep 22, 2025

What

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES πŸ’š
  • NO ❌

Copy link
Contributor

πŸ‘‹ Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Helpful Resources

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
    • You can specify a custom changelog by passing changelog. Example: /bump-version changelog="My cool update"
    • Leaving the changelog arg blank will auto-populate the changelog from the PR title.
  • /run-cat-tests - Runs legacy CAT tests (Connector Acceptance Tests)
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
  • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
  • /poe source example lock - Alias for /poe connector source-example lock.
  • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
  • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.

πŸ“ Edit this welcome message.

@maxi297
Copy link
Contributor Author

maxi297 commented Sep 22, 2025

Regression tests:

EDIT: did not run because no testing candidates were found. I'll handpick some of these and create another run

@maxi297
Copy link
Contributor Author

maxi297 commented Sep 22, 2025

/format-fix

Format-fix job started... Check job output.

βœ… Changes applied successfully. (ca630ad)

Copy link
Contributor

github-actions bot commented Sep 22, 2025

source-slack Connector Test Results

43 tests   37 βœ…β€ƒβ€ƒ42s ⏱️
 2 suites   6 πŸ’€
 2 files     0 ❌

Results for commit e605da3.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 22, 2025

Deploy preview for airbyte-docs ready!

βœ… Preview
https://airbyte-docs-aa3np4ft6-airbyte-growth.vercel.app

Built with commit e605da3.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

github-actions bot commented Sep 22, 2025

source-sftp-bulk Connector Test Results

6 tests   4 βœ…β€ƒβ€ƒ11s ⏱️
2 suites  2 πŸ’€
2 files    0 ❌

Results for commit 22c2fc4.

♻️ This comment has been updated with latest results.

data:
resourceRequirements:
jobSpecific:
- jobType: check_connection
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started from master where the formatting was wrong. You can ignore this as it'll disappear once I merge master into this

Copy link
Collaborator

@darynaishchenko darynaishchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your change makes sense to me, so I'm approving.
But please rerun regression tests for threads stream, just to make sure we didn't miss anything. Regression tests you've linked failed because no test candidates were found.

@maxi297
Copy link
Contributor Author

maxi297 commented Sep 23, 2025

@darynaishchenko because of the breaking changes, there is no viable connection to run regression tests for. Is there an alternative apart from waiting or running locally?

@darynaishchenko
Copy link
Collaborator

@darynaishchenko because of the breaking changes, there is no viable connection to run regression tests for. Is there an alternative apart from waiting or running locally?

@maxi297 Looks like waiting or running locally is the only way to run regression tests in this case. I tried to find some candidates that are on latest version and have threads but nothing found.

@maxi297
Copy link
Contributor Author

maxi297 commented Sep 30, 2025

New batch of regression tests:

EDIT: regression tests was failing since airbytehq/airbyte-python-cdk#777 so I restarted a batch.

Note that I expect threads to fail with returning a different number of records because it has been updated to CDK 7.1.1 without having the state migration logic hence I assume that the parent stream states are not updated using the child state value

@maxi297
Copy link
Contributor Author

maxi297 commented Sep 30, 2025

Regression tests is failing and will always be failing because of airbytehq/airbyte-python-cdk#777 in the control version. I tested this locally and have similar result on 3.1.0 and the target version. I'll merge

@maxi297 maxi297 merged commit 00c3e56 into master Sep 30, 2025
34 of 35 checks passed
@maxi297 maxi297 deleted the cdk7_migration/slack branch September 30, 2025 17:42
frifriSF59 pushed a commit that referenced this pull request Oct 1, 2025
Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants