-
Notifications
You must be signed in to change notification settings - Fork 4.8k
chore: slack up cdk version #66566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: slack up cdk version #66566
Conversation
π Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
Regression tests:
EDIT: did not run because no testing candidates were found. I'll handpick some of these and create another run |
/format-fix
|
|
Deploy preview for airbyte-docs ready! β
Preview Built with commit e605da3. |
|
data: | ||
resourceRequirements: | ||
jobSpecific: | ||
- jobType: check_connection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started from master where the formatting was wrong. You can ignore this as it'll disappear once I merge master into this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your change makes sense to me, so I'm approving.
But please rerun regression tests for threads stream, just to make sure we didn't miss anything. Regression tests you've linked failed because no test candidates were found.
@darynaishchenko because of the breaking changes, there is no viable connection to run regression tests for. Is there an alternative apart from waiting or running locally? |
@maxi297 Looks like waiting or running locally is the only way to run regression tests in this case. I tried to find some candidates that are on latest version and have threads but nothing found. |
New batch of regression tests:
EDIT: regression tests was failing since airbytehq/airbyte-python-cdk#777 so I restarted a batch.
Note that I expect threads to fail with returning a different number of records because it has been updated to CDK 7.1.1 without having the state migration logic hence I assume that the parent stream states are not updated using the child state value |
Regression tests is failing and will always be failing because of airbytehq/airbyte-python-cdk#777 in the control version. I tested this locally and have similar result on 3.1.0 and the target version. I'll merge |
Co-authored-by: Octavia Squidington III <[email protected]>
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?