-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Rbroughan/fix proto input stream hang #66576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, had a a few nits + question about exceptions in exception handling but otherwise
...e-cdk/bulk/core/load/src/main/kotlin/io/airbyte/cdk/load/dataflow/pipeline/PipelineRunner.kt
Outdated
Show resolved
Hide resolved
...e-cdk/bulk/core/load/src/main/kotlin/io/airbyte/cdk/load/dataflow/pipeline/PipelineRunner.kt
Show resolved
Hide resolved
...e-cdk/bulk/core/load/src/main/kotlin/io/airbyte/cdk/load/dataflow/pipeline/PipelineRunner.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3d2f8df
to
1367b4f
Compare
1367b4f
to
b1fa2ea
Compare
What
Fixes hanging in other pipelines when one parallel pipeline would fail when using PROTO data medium.
How
To Read
PipelineRunner
— addsExceptionHandler
for propagating input stream closes and capturing failure cause to rethrowOther
DispatcherBeanFactory
PipelineRunner.kt
for legibilitySocketInputStream
— closing the upstream channel causes a source exception to take precedence over the destination exception and must be avoided.