Skip to content

Conversation

aapatankar
Copy link

Aliasing a column as row_number prevents a similarly named column in the source from syncing to Snowflake. ROW_NUMBER is already registered as a Snowflake keyword. It should not be used as a column alias

What

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • [ X] YES 💚
  • NO ❌

Aliasing a column as row_number prevents a similarly named column in the source from syncing to Snowflake. ROW_NUMBER is already registered as a Snowflake keyword. It should not be used as a column alias
@aapatankar aapatankar requested a review from a team as a code owner September 23, 2025 17:24
@CLAassistant
Copy link

CLAassistant commented Sep 23, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

👋 Welcome to Airbyte!

Thank you for your contribution from aapatankar/airbyte! We're excited to have you in the Airbyte community.

Helpful Resources

PR Slash Commands

As needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
  • /run-connector-tests - Runs connector tests.
  • /run-cat-tests - Runs CAT tests.
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).

If you have any questions, feel free to ask in the PR comments or join our Slack community.

Tips for Working with CI

  1. Pre-Release Checks. Please pay attention to these, as they contain standard checks on the metadata.yaml file, docs requirements, etc. If you need help resolving a pre-release check, please ask a maintainer.
    • Note: If you are creating a new connector, please be sure to replace the default logo.svg file with a suitable icon.
  2. Connector CI Tests. Some failures here may be expected if your tests require credentials. Please review these results to ensure (1) unit tests are passing, if applicable, and (2) integration tests pass to the degree possible and expected.
  3. (Optional.) BYO Connector Credentials for tests in your fork. You can optionally set up your fork with BYO credentials for your connector. This can significantly speed up your review, ensuring your changes are fully tested before the maintainers begin their review.

📝 Edit this welcome message.

@aapatankar aapatankar changed the title 🐛 destination-snowflake: Rename column alias of row_number to _airbyte_intermediate_data_row_number 🐛 destination-snowflake: Fix to enable syncing a row_number column from the source to Snowflake Sep 24, 2025
Updated the subject of version 3.15.11 to clarify the fix related to syncing a row_number column.
@DanyloGL
Copy link
Collaborator

DanyloGL commented Oct 8, 2025

@aapatankar hi, could you please resolve conflicts? After this we will review your PR.
Thanks!

@DanyloGL DanyloGL moved this from Waiting Eng Team to Waiting Contributor in 🧑‍🏭 Community Pull Requests Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Waiting Contributor

Development

Successfully merging this pull request may close these issues.

4 participants