-
Notifications
You must be signed in to change notification settings - Fork 4.8k
🐛 destination-snowflake: Fix to enable syncing a row_number column from the source to Snowflake #66591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aapatankar
wants to merge
11
commits into
airbytehq:master
Choose a base branch
from
aapatankar:row_number_column_cant_sync_to_snowflake_destination
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
🐛 destination-snowflake: Fix to enable syncing a row_number column from the source to Snowflake #66591
aapatankar
wants to merge
11
commits into
airbytehq:master
from
aapatankar:row_number_column_cant_sync_to_snowflake_destination
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aliasing a column as row_number prevents a similarly named column in the source from syncing to Snowflake. ROW_NUMBER is already registered as a Snowflake keyword. It should not be used as a column alias
👋 Welcome to Airbyte!Thank you for your contribution from aapatankar/airbyte! We're excited to have you in the Airbyte community. Helpful Resources
PR Slash CommandsAs needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:
If you have any questions, feel free to ask in the PR comments or join our Slack community. Tips for Working with CI
|
Updated the subject of version 3.15.11 to clarify the fix related to syncing a row_number column.
@aapatankar hi, could you please resolve conflicts? After this we will review your PR. |
…_cant_sync_to_snowflake_destination
…nowflake_destination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aliasing a column as row_number prevents a similarly named column in the source from syncing to Snowflake. ROW_NUMBER is already registered as a Snowflake keyword. It should not be used as a column alias
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?