chore(source-gcs) update to airbyte-cdk v7 #66671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
|
/format-fix
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Deploy preview for airbyte-docs ready! ✅ Preview Built with commit c5e5ca1. |
|
Regression tests:local run as gha wasn't able to find connections 
GHA: https://github.com/airbytehq/airbyte/actions/runs/18012486891 |
darynaishchenko
changed the title
maxi297
reviewed
Sep 30, 2025
airbyte-integrations/connectors/source-gcs/source_gcs/stream_reader.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-gcs/source_gcs/stream_reader.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-gcs/source_gcs/stream_reader.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-gcs/integration_tests/spec.json
Outdated
Show resolved
Hide resolved
|
regression tests: |
maxi297
approved these changes
Oct 6, 2025
aldogonzalez8
approved these changes
Oct 6, 2025
Comment on lines
+74
to
+84
| delivery_method: Union[DeliverRecords, DeliverRawFiles] = Field( | ||
| title="Delivery Method", | ||
| discriminator="delivery_type", | ||
| type="object", | ||
| order=3, | ||
| display_type="radio", | ||
| group="advanced", | ||
| default="use_records_transfer", | ||
| airbyte_hidden=True, | ||
| ) | ||
|
|
Comment on lines
+60
to
+81
| def __init__(self, blob: Any, displayed_uri: str = None, **kwargs): | ||
| super().__init__(**kwargs) | ||
| self.blob = blob | ||
| self.displayed_uri = displayed_uri | ||
| self.id = self.blob.id | ||
| self.created_at = self.blob.time_created.strftime("%Y-%m-%dT%H:%M:%S.%fZ") | ||
| self.updated_at = self.blob.updated.strftime("%Y-%m-%dT%H:%M:%S.%fZ") | ||
|
|
||
| @property | ||
| def size(self) -> int: | ||
| return self.blob.size | ||
|
|
||
| def download_to_local_directory(self, local_file_path: str) -> None: | ||
| self.blob.download_to_filename(local_file_path) | ||
|
|
||
| @property | ||
| def source_file_relative_path(self) -> str: | ||
| return urllib.parse.unquote(self.blob.path) | ||
|
|
||
| @property | ||
| def file_uri_for_logging(self) -> str: | ||
| return urllib.parse.unquote(self.blob.path) |
There was a problem hiding this comment.
Cool @darynaishchenko
matteogp
pushed a commit
that referenced
this pull request
Oct 10, 2025
Co-authored-by: Octavia Squidington III <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Aymericcst
pushed a commit
to Aymericcst/airbyte
that referenced
this pull request
Oct 13, 2025
Co-authored-by: Octavia Squidington III <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
resolves: https://github.com/airbytehq/airbyte-internal-issues/issues/14340
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?