Skip to content

chore: source-freshdesk to cdk7 #67109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 9, 2025
Merged

chore: source-freshdesk to cdk7 #67109

merged 5 commits into from
Oct 9, 2025

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Oct 6, 2025

What

Blocked by airbytehq/airbyte-python-cdk#781

How

Supporting pagination reset using cursor

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Helpful Resources

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
    Example: /update-connector-cdk-version connector=destination-bigquery
  • /bump-version - Bumps connector versions.
    • You can specify a custom changelog by passing changelog. Example: /bump-version changelog="My cool update"
    • Leaving the changelog arg blank will auto-populate the changelog from the PR title.
  • /run-cat-tests - Runs legacy CAT tests (Connector Acceptance Tests)
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
  • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
  • /poe source example lock - Alias for /poe connector source-example lock.
  • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
  • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.

📝 Edit this welcome message.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025 •
edited
Loading

source-freshdesk Connector Test Results

7 tests   4 ✅  17s ⏱️
2 suites  3 💤
2 files    0 ❌

Results for commit 421addb.

♻️ This comment has been updated with latest results.

@maxi297 maxi297 mentioned this pull request Oct 6, 2025
Merged
@maxi297 maxi297 requested a review from brianjlai October 9, 2025 18:41
@maxi297 maxi297 marked this pull request as ready for review October 9, 2025 18:42
@maxi297
Copy link
Contributor Author

maxi297 commented Oct 9, 2025 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (2183de2)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025 •
edited
Loading

Deploy preview for airbyte-docs ready!

✅ Preview
https://airbyte-docs-iqhouwlnh-airbyte-growth.vercel.app

Built with commit 421addb.
This pull request is being automatically deployed with vercel-action

@maxi297
Copy link
Contributor Author

maxi297 commented Oct 9, 2025

It seems like the previous rc version was not fully rolled out because of issues with the tickets stream. The new version without custom components should fix this issue. I don't have visibility on the other streams though so I'll make it a progressive rollout too

brianjlai
brianjlai approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pure bliss when i see components.py erased from the face of the planet

@maxi297 maxi297 merged commit e4bec72 into master Oct 9, 2025
34 checks passed
@maxi297 maxi297 deleted the issue_14339/source_freshdesk_to_cdk_7 branch October 9, 2025 19:46
matteogp pushed a commit that referenced this pull request Oct 10, 2025
@maxi297 @octavia-squidington-iii @matteogp
chore: source-freshdesk to cdk7 (#67109)
7701588 
## What
Blocked by airbytehq/airbyte-python-cdk#781

## How
Supporting pagination reset using cursor

## Review guide
<!--
1. `x.py`
2. `y.py`
-->

## User Impact
<!--
* What is the end result perceived by the user?
* If there are negative side effects, please list them. 
-->

## Can this PR be safely reverted and rolled back?
<!--
* If unsure, leave it blank.
-->
- [x] YES 💚
- [ ] NO ❌

---------

Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianjlai brianjlai brianjlai approved these changes

Assignees

No one assigned

Labels

connectors/source/freshdesk

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxi297 @brianjlai @octavia-squidington-iii