Open
Conversation
This reverts commit 2babf4f.
Added a panel which can open and close with animation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the notifications screen, to make a notification stick permanently, we enter 0 for timeout. But after entering 0 for timeout, the notification is shown and then removed immediately. This is because a string value is assigned to $scope.options.timeOut and timeouts are created for notifications when timeout value is truthy. Line#441 in angular-toastr.tpls.js :
The value for timeOut and extendedTimeOut should be numeric. The number 0 is not truthy, but the string value "0" is truthy.